From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbdF0Uh5 (ORCPT ); Tue, 27 Jun 2017 16:37:57 -0400 Received: from mail-dm3nam03on0088.outbound.protection.outlook.com ([104.47.41.88]:40714 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753428AbdF0Uht (ORCPT ); Tue, 27 Jun 2017 16:37:49 -0400 From: "Kershner, David A" To: Quytelda Kahja , "gregkh@linuxfoundation.org" , "Sell, Timothy C" , "Binder, David Anthony" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl. Thread-Topic: [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl. Thread-Index: AQHS7tSIa1HvCuLGqUyMz0kP5Oy6saI5K6fA Date: Tue, 27 Jun 2017 20:37:47 +0000 Message-ID: References: <20170626233130.5834-1-quytelda@tamalin.org> In-Reply-To: <20170626233130.5834-1-quytelda@tamalin.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: tamalin.org; dkim=none (message not signed) header.d=none;tamalin.org; dmarc=none action=none header.from=unisys.com; x-originating-ip: [192.63.205.31] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR07MB3126;7:7UFzoVOw4rEwlCdFMItibHWg7+Th3Bt2GoqHOUKI5iuQRvOVZYDQQl5pHgk/RyIOCZh+1M+qKl9l4RPwLXrdFwWo/Aq3XvD8CG8n1mds2iI3msj7pvLxHaLvIywUBCIiZ3QYcpxEtkp51GJt/ITDWKl4dHrkLKF7zmnSqKxh4FOyiMavTAGiALb+4OgY80K2n4ulR+to0eOuiCwUaKTxg3gEPfLevruLvA1/1qL4DzyqEGve4wu2pO/8w8JHoRU2YpzsnAmg1XiZqFEruVqo34J689MQUjvzM9RRxlJNrOZA0NckN7641hOYDE1kLuqLQOTej5SaWK2m9yx9jpXYF58ZHJ9sPjF4ooLfQgmzosA6D7kNNmmr3MDldNjzTcyKglRsPRScgTm/0wIdGw+IhrXx36X9ISN70MJUnaTxuTfHnxXI6m3KehY7ok6oBVIPf2Uh20IcN4GfLctecNC+cWjcviEjkTKPGHsgaIK9CEP06HCD7y+FYYY8FX/xAqEn0ae9B0zKsvCFplWGJN1BbdVKaMehqXdmG2vVcBwSCqH+I6Y/p0Zqc7ULkRvbnc6o07L3iUoCiOiNOkM+w4gGzP+OvqHgBPcS2Zgqy5Eu/5fPP5HsY9x1L7NNfgT42+fO261QBKaaXUqMalbB5cLt0YbkeifQaIwPIv8i5rjXBx1vcCYwVmJEAXe4YviFnuHNt2JtwPQMWGaETh7NyLVywm2Qs0KY+1Q2c43jq0A3bwM2NeYz5z6bFc2Wg/0uiwfPLYiaaTe4jg5BTt1cqQDgbvjiCGsP8ifAdGl4+r7ebYk= x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(39410400002)(39400400002)(39850400002)(39860400002)(39450400003)(39840400002)(377454003)(13464003)(54356999)(4326008)(2900100001)(25786009)(53546010)(33656002)(478600001)(53936002)(2501003)(50986999)(189998001)(76176999)(74316002)(72206003)(6246003)(7696004)(8936002)(2950100002)(6636002)(3280700002)(2906002)(66066001)(38730400002)(229853002)(5660300001)(14454004)(305945005)(55016002)(7736002)(3660700001)(86362001)(3846002)(9686003)(77096006)(6436002)(102836003)(81166006)(6506006)(99286003)(6116002)(8676002)(54906002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR07MB3126;H:CY4PR07MB3176.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: 1fe5ff95-e82e-4886-04b0-08d4bd9c5ef5 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095);SRVR:CY4PR07MB3126; x-ms-traffictypediagnostic: CY4PR07MB3126: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(9452136761055)(174360191007938)(788757137089)(167848164394848); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR07MB3126;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR07MB3126; x-forefront-prvs: 0351D213B3 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: unisys.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2017 20:37:47.0496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8d894c2b-238f-490b-8dd1-d93898c5bf83 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3126 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5RKcQ6h022362 > -----Original Message----- > From: Quytelda Kahja [mailto:quytelda@tamalin.org] > Sent: Monday, June 26, 2017 7:32 PM > To: Kershner, David A ; > gregkh@linuxfoundation.org; Sell, Timothy C ; > Binder, David Anthony > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Quytelda > Kahja > Subject: [PATCH] Staging: visorbus: Fix coding style warning from > checkpatch.pl. > > Replace the literal function name "create_bus_instance" with the format > specifier "%s" so it can be dynamically filled by the __func__ macro. > > Signed-off-by: Quytelda Kahja I can't get this to apply to Greg's staging-next branch. It appears to be missing at least patch: commit 9e78fd35d staging: unisys: visorbus: renamed functions like *_bus_instance to match driver namespace Please update and send again. Thanks, David Kershner > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c > b/drivers/staging/unisys/visorbus/visorbus_main.c > index a692561c81c8..b6caa7a98692 100644 > --- a/drivers/staging/unisys/visorbus/visorbus_main.c > +++ b/drivers/staging/unisys/visorbus/visorbus_main.c > @@ -1032,7 +1032,7 @@ create_bus_instance(struct visor_device *dev) > err_debugfs_dir: > debugfs_remove_recursive(dev->debugfs_dir); > kfree(hdr_info); > - dev_err(&dev->device, "create_bus_instance failed: %d\n", err); > + dev_err(&dev->device, "%s failed: %d\n", __func__, err); > return err; > } > > -- > 2.13.2