> -----Original Message----- > From: Joe Perches [mailto:joe@perches.com] > Sent: Friday, December 8, 2017 11:53 AM > To: Greg KH ; Kershner, David A > > Cc: jes.sorensen@gmail.com; linux-kernel@vger.kernel.org; driverdev- > devel@linuxdriverproject.org; *S-Par-Maintainer > ; erik.arfvidson@gmail.com; > wadgaonkarsam@gmail.com > Subject: Re: [PATCH v2] drivers: visorbus: move driver out of staging > > On Fri, 2017-12-08 at 16:39 +0100, Greg KH wrote: > > On Thu, Dec 07, 2017 at 12:11:07PM -0500, David Kershner wrote: > > > Move the visorbus driver out of staging (drivers/staging/unisys/visorbus) > > > and to drivers/visorbus. Modify the configuration and makefiles so they > > > now reference the new location. The s-Par header file visorbus.h that is > > > referenced by all s-Par drivers, is being moved into include/linux. > > Perhaps moving visorbus.h and visorbus_private.h to > drivers/visorbus would be better than adding more > relatively localized #include files to include/linux/ > > what about controlvmchannel? > The file visorbus.h is currently included by 4 drivers: visorbus and 3 other drivers that are staying in staging for now, but we plan to move out soon. The files visorbus_private.h and controlvmchannel.h are only used by the visorbus driver and belong solely in the visorbus directory, no one should be including them besides the visorbus driver. David Kershner