From: "Stankiewicz, Piotr" <piotr.stankiewicz@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
netdev <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate
Date: Wed, 3 Jun 2020 08:49:53 +0000 [thread overview]
Message-ID: <CY4PR11MB15287ACFF4C55F84D43433E9F9880@CY4PR11MB1528.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VfEcm-Mmo7=i40sJ0RqpOgFRpJHxQ9ePWvvqsyRp+=9GA@mail.gmail.com>
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Tuesday, June 2, 2020 5:39 PM
>
> On Tue, Jun 2, 2020 at 12:26 PM Piotr Stankiewicz
> <piotr.stankiewicz@intel.com> wrote:
> >
> > Seeing as there is shorthand available to use when asking for any type
> > of interrupt, or any type of message signalled interrupt, leverage it.
>
> ...
>
> > vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> > - hdev->num_msi,
> > - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > + hdev->num_msi, PCI_IRQ_MSI_TYPES);
>
> ...
>
> > vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
>
> > hdev->num_msi,
> > - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > + PCI_IRQ_MSI_TYPES);
>
> One line as above?
>
It would push the line above 80 characters.
> --
> With Best Regards,
> Andy Shevchenko
BR,
Piotr
next prev parent reply other threads:[~2020-06-03 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 9:21 [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-02 15:39 ` Andy Shevchenko
2020-06-03 8:49 ` Stankiewicz, Piotr [this message]
2020-06-03 10:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB15287ACFF4C55F84D43433E9F9880@CY4PR11MB1528.namprd11.prod.outlook.com \
--to=piotr.stankiewicz@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).