From: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: "x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bp@suse.de" <bp@suse.de>
Subject: RE: [PATCH] x86/smpboot: Don't do mwait_play_dead() on AMD systems
Date: Tue, 3 Apr 2018 14:47:46 +0000 [thread overview]
Message-ID: <CY4PR12MB15574BF988D5E24957D27471F8A50@CY4PR12MB1557.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20180403144043.23o5aijs4hlyj2dj@gmail.com>
> -----Original Message-----
> From: Ingo Molnar <mingo.kernel.org@gmail.com> On Behalf Of Ingo Molnar
> Sent: Tuesday, April 3, 2018 10:41 AM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: x86@kernel.org; linux-kernel@vger.kernel.org; bp@suse.de
> Subject: Re: [PATCH] x86/smpboot: Don't do mwait_play_dead() on AMD
> systems
>
>
> * Ghannam, Yazen <Yazen.Ghannam@amd.com> wrote:
>
> > > -----Original Message-----
> > > From: Ingo Molnar <mingo.kernel.org@gmail.com> On Behalf Of Ingo
> Molnar
> > > Sent: Tuesday, April 3, 2018 7:04 AM
> > > To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> > > Cc: x86@kernel.org; linux-kernel@vger.kernel.org; bp@suse.de
> > > Subject: Re: [PATCH] x86/smpboot: Don't do mwait_play_dead() on AMD
> > > systems
> > >
> > >
> > > * Yazen Ghannam <Yazen.Ghannam@amd.com> wrote:
> > >
> > > > From: Yazen Ghannam <yazen.ghannam@amd.com>
> > > >
> > > > Recent AMD systems support using MWAIT for C1 state. However, MWAIT
> will
> > > > not allow deeper cstates than C1 on current systems.
> > > >
> > > > With play_dead() we expect the OS to use the deepest state available.
> > > > The deepest state available on AMD systems is reached through SystemIO
> > > > or HALT. If MWAIT is available, we use it instead of the other methods,
> > > > so we never reach the deepest state.
> > > >
> > > > Don't try to use MWAIT to play_dead() on AMD systems. Instead, we'll use
> > > > CPUIDLE to enter the deepest state advertised by firmware. If CPUIDLE is
> > > > not available then we fallback to HALT.
> > > >
> > > > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > > > ---
> > > > arch/x86/kernel/smpboot.c | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> > > > index ff99e2b6fc54..67cf00b25f83 100644
> > > > --- a/arch/x86/kernel/smpboot.c
> > > > +++ b/arch/x86/kernel/smpboot.c
> > > > @@ -1536,6 +1536,9 @@ static inline void mwait_play_dead(void)
> > > > void *mwait_ptr;
> > > > int i;
> > > >
> > > > + /* Don't try native MWAIT on AMD. Stick to CPUIDLE and HALT. */
> > > > + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
> > > > + return;
> > >
> > > The comment should mainly explain the 'why is this done', not the 'what is
> done'
> > > which is pretty obvious from the code ...
> > >
> >
> > Yes, I'll drop that comment since the commit message has the explanation.
>
> Or rather, explain the 'why' in the comment, because otherwise this is a pretty
> obscure condition that is not self-documenting?
>
Okay, how about this?
"MWAIT only provides shallow Cstates on AMD systems. Fallback to CPUIDLE and
HALT to have access to deeper Cstates."
Thanks,
Yazen
prev parent reply other threads:[~2018-04-03 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 18:34 [PATCH] x86/smpboot: Don't do mwait_play_dead() on AMD systems Yazen Ghannam
2018-04-03 11:03 ` Ingo Molnar
2018-04-03 13:55 ` Ghannam, Yazen
2018-04-03 14:40 ` Ingo Molnar
2018-04-03 14:47 ` Ghannam, Yazen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR12MB15574BF988D5E24957D27471F8A50@CY4PR12MB1557.namprd12.prod.outlook.com \
--to=yazen.ghannam@amd.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).