* Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible
[not found] <CAL_JsqJR6EfDsmwPmXxgdaC1GB7CLGYpjmDnOkD_f53Frsq6LA@mail.gmail.com>
@ 2021-11-03 2:48 ` Giulio Benetti
0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2021-11-03 2:48 UTC (permalink / raw)
To: Rob Herring
Cc: Jesse Taube, NXP Linux Team, Michael Turquette, Stephen Boyd,
Shawn Guo, Sascha Hauer, Sascha Hauer, Fabio Estevam,
Ulf Hansson, Dong Aisheng, Stefan Agner, Linus Walleij,
Greg Kroah-Hartman, Arnd Bergmann, Olof Johansson, SoC Team,
Russell King, Abel Vesa, Adrian Hunter, Jiri Slaby,
Nobuhiro Iwamatsu, Leonard Crestez, Anson Huang, Fugang Duan,
linux-clk, devicetree, linux-arm-kernel, linux-kernel, linux-mmc,
open list:GPIO SUBSYSTEM, open list:SERIAL DRIVERS
Hello Rob, Jesse, All,
> Il giorno 3 nov 2021, alle ore 01:49, Rob Herring <robh@kernel.org> ha scritto:
>
> On Mon, Nov 1, 2021 at 6:34 PM Jesse Taube <mr.bossman075@gmail.com> wrote:
>>
>>
>>
>>> On 11/1/21 16:13, Rob Herring wrote:
>>> On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
>>>> Add i.MXRT documentation for compatible string.
>>>>
>>>> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>>> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
>>>> ---
>>>> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>>>> index a90c971b4f1f..4b4340def2aa 100644
>>>> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>>>> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>>>> @@ -21,6 +21,7 @@ properties:
>>>> - fsl,ls1028a-lpuart
>>>> - fsl,imx7ulp-lpuart
>>>> - fsl,imx8qm-lpuart
>>>> + - fsl,imxrt-lpuart
>>>
>>> Actually, 'rt' is not a single part is it? If the variations are same
>>> die, but fused off then no need to distinguish. Otherwise, these should
>>> be SoC specific.
>>>
>> I don't exactly know what "but fused off" means I would assume
>> disconnected but on-die?
>
> Right. Or not pinned out is another possibility.
>
>> The imxrtxxx is a series that has the same UART
>> controller across them. Should I add ACK?
>
> Looking at the errata docs briefly, there's at least 2 die as some of
> the errata docs give the mask id. So they aren't necessarily 'the
> same'.
Thank you for pointing, we’ve missed this particular.
> You want the compatible strings to be specific enough to handle
> any differences or errata. If you only care about the imxrt1050, then
> I'd just use that and move on.
We plan to add from imxrt1020 to imxrt1170 and eventual new SoC, so we definitely need separate
.compatible strings.
@Jesse, can you please update with ‘fsl,imxrt1050”?
> Otherwise, maybe someone from NXP wants
> to comment?
Any NXP comment is welcome!
Best regards
Giulio Benetti
Benetti engineering sas
>
> Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible
2021-11-01 20:13 ` Rob Herring
@ 2021-11-01 23:34 ` Jesse Taube
0 siblings, 0 replies; 5+ messages in thread
From: Jesse Taube @ 2021-11-01 23:34 UTC (permalink / raw)
To: Rob Herring
Cc: linux-imx, mturquette, sboyd, shawnguo, s.hauer, kernel,
festevam, ulf.hansson, aisheng.dong, stefan, linus.walleij,
gregkh, arnd, olof, soc, linux, abel.vesa, adrian.hunter,
jirislaby, giulio.benetti, nobuhiro1.iwamatsu, leonard.crestez,
b20788, fugang.duan, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, linux-mmc, linux-gpio, linux-serial
On 11/1/21 16:13, Rob Herring wrote:
> On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
>> Add i.MXRT documentation for compatible string.
>>
>> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
>> ---
>> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> index a90c971b4f1f..4b4340def2aa 100644
>> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
>> @@ -21,6 +21,7 @@ properties:
>> - fsl,ls1028a-lpuart
>> - fsl,imx7ulp-lpuart
>> - fsl,imx8qm-lpuart
>> + - fsl,imxrt-lpuart
>
> Actually, 'rt' is not a single part is it? If the variations are same
> die, but fused off then no need to distinguish. Otherwise, these should
> be SoC specific.
>
I don't exactly know what "but fused off" means I would assume
disconnected but on-die? The imxrtxxx is a series that has the same UART
controller across them. Should I add ACK?
> Same applies to other compatible strings.
>
>> - items:
>> - const: fsl,imx8qxp-lpuart
>> - const: fsl,imx7ulp-lpuart
>> --
>> 2.33.0
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible
2021-10-24 15:40 ` [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible Jesse Taube
2021-11-01 20:11 ` Rob Herring
@ 2021-11-01 20:13 ` Rob Herring
2021-11-01 23:34 ` Jesse Taube
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2021-11-01 20:13 UTC (permalink / raw)
To: Jesse Taube
Cc: linux-imx, mturquette, sboyd, shawnguo, s.hauer, kernel,
festevam, ulf.hansson, aisheng.dong, stefan, linus.walleij,
gregkh, arnd, olof, soc, linux, abel.vesa, adrian.hunter,
jirislaby, giulio.benetti, nobuhiro1.iwamatsu, leonard.crestez,
b20788, fugang.duan, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, linux-mmc, linux-gpio, linux-serial
On Sun, Oct 24, 2021 at 11:40:22AM -0400, Jesse Taube wrote:
> Add i.MXRT documentation for compatible string.
>
> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index a90c971b4f1f..4b4340def2aa 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -21,6 +21,7 @@ properties:
> - fsl,ls1028a-lpuart
> - fsl,imx7ulp-lpuart
> - fsl,imx8qm-lpuart
> + - fsl,imxrt-lpuart
Actually, 'rt' is not a single part is it? If the variations are same
die, but fused off then no need to distinguish. Otherwise, these should
be SoC specific.
Same applies to other compatible strings.
> - items:
> - const: fsl,imx8qxp-lpuart
> - const: fsl,imx7ulp-lpuart
> --
> 2.33.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible
2021-10-24 15:40 ` [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible Jesse Taube
@ 2021-11-01 20:11 ` Rob Herring
2021-11-01 20:13 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-11-01 20:11 UTC (permalink / raw)
To: Jesse Taube
Cc: aisheng.dong, linux-serial, Mr.Bossman075, linux-arm-kernel,
linus.walleij, olof, adrian.hunter, linux, linux-kernel,
jirislaby, linux-gpio, devicetree, sboyd, kernel, s.hauer,
linux-clk, arnd, mturquette, abel.vesa, giulio.benetti,
leonard.crestez, ulf.hansson, stefan, soc, gregkh, festevam,
shawnguo, linux-imx, robh+dt, linux-mmc, fugang.duan, b20788,
nobuhiro1.iwamatsu
On Sun, 24 Oct 2021 11:40:22 -0400, Jesse Taube wrote:
> Add i.MXRT documentation for compatible string.
>
> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible
2021-10-24 15:40 [PATCH 00/13] This patchset aims to add initial support for the i.MXRT10xx family Jesse Taube
@ 2021-10-24 15:40 ` Jesse Taube
2021-11-01 20:11 ` Rob Herring
2021-11-01 20:13 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Jesse Taube @ 2021-10-24 15:40 UTC (permalink / raw)
To: linux-imx
Cc: mturquette, sboyd, robh+dt, shawnguo, s.hauer, kernel, festevam,
ulf.hansson, aisheng.dong, stefan, linus.walleij, gregkh, arnd,
olof, soc, linux, abel.vesa, adrian.hunter, jirislaby,
giulio.benetti, nobuhiro1.iwamatsu, leonard.crestez, b20788,
Mr.Bossman075, fugang.duan, linux-clk, devicetree,
linux-arm-kernel, linux-kernel, linux-mmc, linux-gpio,
linux-serial
Add i.MXRT documentation for compatible string.
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index a90c971b4f1f..4b4340def2aa 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -21,6 +21,7 @@ properties:
- fsl,ls1028a-lpuart
- fsl,imx7ulp-lpuart
- fsl,imx8qm-lpuart
+ - fsl,imxrt-lpuart
- items:
- const: fsl,imx8qxp-lpuart
- const: fsl,imx7ulp-lpuart
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-03 2:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAL_JsqJR6EfDsmwPmXxgdaC1GB7CLGYpjmDnOkD_f53Frsq6LA@mail.gmail.com>
2021-11-03 2:48 ` [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible Giulio Benetti
2021-10-24 15:40 [PATCH 00/13] This patchset aims to add initial support for the i.MXRT10xx family Jesse Taube
2021-10-24 15:40 ` [PATCH 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible Jesse Taube
2021-11-01 20:11 ` Rob Herring
2021-11-01 20:13 ` Rob Herring
2021-11-01 23:34 ` Jesse Taube
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).