From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Simmons, James A." <simmonsja@ornl.gov>,
Shivani Bhardwaj <shivanib134@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] Staging: lustre: module: Replace function calls
Date: Sat, 7 Nov 2015 19:27:16 +0000 [thread overview]
Message-ID: <D12D10D3-A25C-41E3-A1EC-D69982D1BFBF@intel.com> (raw)
In-Reply-To: <20151107111523.GG18797@mwanda>
On Nov 7, 2015, at 04:15, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Nov 06, 2015 at 10:04:41PM +0000, Simmons, James A. wrote:
>>> From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf Of Shivani Bhardwaj
>>> Sent: Friday, November 06, 2015 12:18 PM
>>> To: gregkh@linuxfoundation.org
>>> Cc: oleg.drokin@intel.com; devel@driverdev.osuosl.org; andreas.dilger@intel.com; linux-kernel@vger.kernel.org
>>> Subject: [PATCH 1/3] Staging: lustre: module: Replace function calls
>>>
>>> Replace the calls of function cfs_trace_free_string_buffer() with
>>> kfree() as the former function is not required.
>>>
>>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>>> ---
>>> drivers/staging/lustre/lustre/libcfs/module.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Acked-by: James Simmons <jsimmons@infradead.org>
>>
>> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
>> index 50e8fd2..516a9e7 100644
>> --- a/drivers/staging/lustre/lustre/libcfs/module.c
>> +++ b/drivers/staging/lustre/lustre/libcfs/module.c
>> @@ -392,7 +392,7 @@ static int __proc_dobitmasks(void *data, int write,
>> } else {
>
> Why do your acks include the original diff without the "> " prefix? How
> are you even managing that trick?
I was wondering the same, though it does look nicer.
Cheers, Andreas
next prev parent reply other threads:[~2015-11-07 19:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 17:17 [PATCH 0/3] Remove wrapper function and clean up the code Shivani Bhardwaj
2015-11-06 17:18 ` [PATCH 1/3] Staging: lustre: module: Replace function calls Shivani Bhardwaj
2015-11-06 22:04 ` Simmons, James A.
2015-11-07 11:15 ` Dan Carpenter
2015-11-07 19:27 ` Dilger, Andreas [this message]
2015-11-06 17:19 ` [PATCH 2/3] Staging: lustre: tracefile: Remove wrapper function Shivani Bhardwaj
2015-11-06 22:03 ` Simmons, James A.
2015-11-06 17:19 ` [PATCH 3/3] Staging: lustre: tracefile: Remove function prototype Shivani Bhardwaj
2015-11-07 7:32 ` Dilger, Andreas
2015-11-07 7:50 ` Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D12D10D3-A25C-41E3-A1EC-D69982D1BFBF@intel.com \
--to=andreas.dilger@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=shivanib134@gmail.com \
--cc=simmonsja@ornl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).