From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D6FC54FCB for ; Mon, 20 Apr 2020 13:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D10822070B for ; Mon, 20 Apr 2020 13:15:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=flygoat.com header.i=jiaxun.yang@flygoat.com header.b="goRgelHe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgDTNPv (ORCPT ); Mon, 20 Apr 2020 09:15:51 -0400 Received: from sender3-op-o12.zoho.com.cn ([124.251.121.243]:17830 "EHLO sender3-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgDTNPu (ORCPT ); Mon, 20 Apr 2020 09:15:50 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1587388518; cv=none; d=zoho.com.cn; s=zohoarc; b=bnitXJ6a5awYMcxWW+C35z/i3wlEbUXAGAEF3Vr3PnGr3Zd4DV6H1WNb3ucn5QqMxhYKsY89WrMGn18COeDuxvidBLr8zrJ/zT+gUnRiqtcw7uY7yz9ADTfwOp7bO1ydXQMlC63Jn8hRntXiYrud5aecVa3fo6rQHzqkIIIrzcg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1587388518; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:Reply-To:References:Subject:To; bh=m4ElzxvozIiJ7VtYC556c5aJNi4fFs2JdOzX4iTtIo0=; b=m/OIjwU5t1A7V8M6IN65/LkA+HDzvNTVl36M+q+0quJdys2oHGmKju8rCZ7u1iS6qObFHoLf7+HUKLuLYlyhjBu19L7V0MEFV2CqdLvBP5DQ3Ph5R7t7rSCnN6wkHwaj8KhgfL+rXeOiryWpsKBCPUxEa1uXNeTDSEvkEyis/JY= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=flygoat.com; spf=pass smtp.mailfrom=jiaxun.yang@flygoat.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1587388518; s=mail; d=flygoat.com; i=jiaxun.yang@flygoat.com; h=Date:From:To:CC:Subject:Reply-to:In-Reply-To:References:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=m4ElzxvozIiJ7VtYC556c5aJNi4fFs2JdOzX4iTtIo0=; b=goRgelHeylk+CXxKkvSFHVPAE3/YCHE8eojrE9VZaL02o7PzOe0jnY3J+wd3PvqQ PlHdxSBVoF8sO8KcNsp9YxWD7Q2ug36TbSKq7E2JNazVIwv6eKxt6vx3Orx9CchVaLw W+ctDD+4a3bZszmw7jGH68ebHfAEq15qCYWXnv0s= Received: from [127.0.0.1] (115.205.241.167 [115.205.241.167]) by mx.zoho.com.cn with SMTPS id 1587388514770656.1781461570575; Mon, 20 Apr 2020 21:15:14 +0800 (CST) Date: Mon, 20 Apr 2020 21:15:13 +0800 From: Jiaxun Yang To: maobibo CC: linux-mips@vger.kernel.org, Thomas Bogendoerfer , Rob Herring , Huacai Chen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 1/5] MIPS: Loongson64: Remove dead RTC code User-Agent: K-9 Mail for Android Reply-to: jiaxun.yang@flygoat.com In-Reply-To: References: <20200420073347.157230-1-jiaxun.yang@flygoat.com> <20200420073347.157230-2-jiaxun.yang@flygoat.com> <15923f8b-7278-f510-e06a-99751bd68048@loongson.cn> <20200420201312.7afe1bb7@flygoat-x1e> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoCNMailClient: External Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E4=BA=8E 2020=E5=B9=B44=E6=9C=8820=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=889= :04:52, maobibo =E5=86=99=E5=88=B0: > > >On 04/20/2020 08:13 PM, Jiaxun Yang wrote: >> Hi Bibi, >>=20 >> Thanks for your review=2E >>=20 >> Pretty sure=2E It is mc146818 specified, it can never work on LS7A/LS2K >> which have another RTC implementation=2E >>=20 >> I have performed boot test with this patch=2E >> Kernel have safety fallback on platforms without this callback=2E=20 >Although it boots ok, the wall time will be 0 for every boot since it doe= s not read from rtc Not a big deal :-) It must be removed unless we can come out a solution fits both mc146818 and Loongson's in-house design RTC=2E Thanks > >regards >bibo, mao > --=20 Jiaxun Yang