From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbdA1Msv (ORCPT ); Sat, 28 Jan 2017 07:48:51 -0500 Received: from mail-he1eur01on0070.outbound.protection.outlook.com ([104.47.0.70]:55200 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751220AbdA1MrP (ORCPT ); Sat, 28 Jan 2017 07:47:15 -0500 From: Majd Dibbiny To: Dan Carpenter CC: Doug Ledford , Bart Van Assche , "christophe.jaillet@wanadoo.fr" , "hal.rosenstock@gmail.com" , "sean.hefty@intel.com" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] IB/cma: Fix reversed test Thread-Topic: [PATCH] IB/cma: Fix reversed test Thread-Index: AQHSeJ/pUxTcXtVnrk2+nRMGTnEaiqFM2FCAgAArAwCAAHOOgIAAYPOA Date: Sat, 28 Jan 2017 12:47:10 +0000 Message-ID: References: <20170127131535.19918-1-christophe.jaillet@wanadoo.fr> <1485552696.13218.0.camel@sandisk.com> <1485561952.2432.31.camel@redhat.com> <20170128065927.GP4149@mwanda> In-Reply-To: <20170128065927.GP4149@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=majd@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [46.121.82.152] x-ms-office365-filtering-correlation-id: 6c1ebdee-0668-40dc-1213-08d4477bc6e8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401076);SRVR:DB6PR0501MB2072; x-microsoft-exchange-diagnostics: 1;DB6PR0501MB2072;7:JmtVngGnwLMiq+r8UM0a68rG7190fob9tHeRU6tQ1LRwl8MH9u8sCVQbYMJbHaayW8VRXc8xzjgS2yFL6Ua1GCye9qY5UHeIg+jJfpRwPkyAUe35k7hmYa3Jii8IXxpxIUpFmhZwg3mkFYG8oFwGxKcMDc4U9cdJ2QOnYTr7yrDsM/7CdRg3toXxT0TE8e7MP4jnFFF2+Z9wjm2fbL+HYbf4zlbP1oiWFJbS9tMyCPY9JzTXj5W0f+Pu/4V7mOJ9si2IQnN9DaF7RIAjkSLXUvkMv3lEv15ZO8Nly/+UXOgMS+eV/hkYuW2jyoS1bOE639FShrEt69zOYLKL2Y2NWbNL55CN95GdtMyy0PLO+Mr2cy74/7DZ6Xy0lN62Sd7gVOLbddT7D3xZgnJIUk3r7VkI5G6d/dIYrFBryOMYc24T22FWgRs0vNwrJKUp0VUWXEkFX3cWAXjLjPpOKq/h+w== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:DB6PR0501MB2072;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0501MB2072; x-forefront-prvs: 02015246A9 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39450400003)(39840400002)(24454002)(377454003)(199003)(189002)(38730400001)(39060400001)(77096006)(6486002)(25786008)(2950100002)(6436002)(6916009)(6506006)(8656002)(110136003)(5660300001)(99286003)(81156014)(81166006)(8676002)(6306002)(189998001)(6512007)(2900100001)(229853002)(92566002)(966004)(82746002)(83716003)(86362001)(3280700002)(305945005)(7736002)(9886003)(105586002)(3660700001)(2906002)(68736007)(101416001)(93886004)(50986999)(54356999)(76176999)(33656002)(106356001)(6116002)(102836003)(3846002)(106116001)(5003630100001)(8936002)(122556002)(54906002)(97736004)(53936002)(36756003)(66066001)(4326007)(104396002)(422495003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0501MB2072;H:DB6PR0501MB2072.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <38FDCE8C1DA34C4DAA76ED29707EBE10@Mellanox365.onmicrosoft.com> MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2017 12:47:10.3274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2072 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0SD3NC6030357 We have message sniffer that checks for unwanted prints after each test.. Sent from my iPhone > On Jan 28, 2017, at 8:59 AM, Dan Carpenter wrote: > > On Fri, Jan 27, 2017 at 07:05:52PM -0500, Doug Ledford wrote: >>> Do you think this patch needs "Fixes:" and "Cc: stable" tags? >> >> It does not. > > We always should have fixes tags. > > When I'm reviewing, I try to look up the patch which introduced the bug > so I can figure out what the intent was. Having a Fixes tag speeds up > my work. > > Looking at how the bug was introduced sometimes helps to prevent bugs > from recurring in the future. For example, I've seen several bugs > introduced because the right people weren't on the CC to review it. For > this particular bug it feels like probably this bug could have been > detected with more testing. I doubt it would have made it into a > released kernel. > > Also it let's you CC the original authors and hopefully they can Ack it. > > regards, > dan carpenter > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html