From: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
To: "Matt Domsch" <Matt_Domsch@Dell.com>,
<linux-ia64@vger.kernel.org>, <ak@suse.de>,
<openipmi-developer@lists.sourceforge.net>, <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2.6.15] ia64: use i386 dmi_scan.c
Date: Fri, 6 Jan 2006 11:03:17 -0800 [thread overview]
Message-ID: <D36CE1FCEFD3524B81CA12C6FE5BCAB00C081899@fmsmsx406.amr.corp.intel.com> (raw)
Matt Domsch <> wrote:
> Enable DMI table parsing on ia64.
...
> +#ifndef CONFIG_EFI
> +void __init dmi_scan_machine(void)
> +{
> char __iomem *p, *q;
> + int rc;
Hi Matt,
You could potentially consolidate the two dmi_scan_machine functions
and lose the ifdef (and duplication) by checking efi_enabled instead.
'efi_enabled' is already ifdef'd in the EFI header (defined to 1 for
ia64) specifically for this situation.
matt
next reply other threads:[~2006-01-06 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 19:03 Tolentino, Matthew E [this message]
2006-01-06 22:36 ` [PATCH 2.6.15] ia64: use i386 dmi_scan.c Matt Domsch
-- strict thread matches above, loose matches on Subject: below --
2006-01-19 14:19 Tolentino, Matthew E
2006-01-04 22:16 [PATCH 2.6.15 1/2] " Matt Domsch
2006-01-06 17:21 ` [PATCH 2.6.15] " Matt Domsch
2006-01-06 22:39 ` Matt Domsch
2006-01-14 0:24 ` Bjorn Helgaas
2006-01-14 0:45 ` Alan Cox
2006-01-14 1:19 ` Andi Kleen
2006-01-14 5:05 ` Bjorn Helgaas
2006-01-18 0:17 ` Bjorn Helgaas
2006-01-18 2:32 ` Andi Kleen
2006-01-18 15:53 ` Bjorn Helgaas
2006-01-18 17:29 ` Bjorn Helgaas
2006-03-17 23:54 ` Andrew Morton
2006-03-18 14:56 ` Matt Domsch
2006-03-18 15:43 ` Matt Domsch
2006-03-18 19:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D36CE1FCEFD3524B81CA12C6FE5BCAB00C081899@fmsmsx406.amr.corp.intel.com \
--to=matthew.e.tolentino@intel.com \
--cc=Matt_Domsch@Dell.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).