From: Fred Klassen <fklassen@appneta.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Shuah Khan <shuah@kernel.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net 1/4] net/udp_gso: Allow TX timestamp with UDP GSO
Date: Sat, 25 May 2019 13:09:33 -0700 [thread overview]
Message-ID: <D37889F4-104C-4E9A-B5CB-A0FCCEFF2D93@appneta.com> (raw)
In-Reply-To: <CAF=yD-+4g-HjmCnDWaVfdsyruePXqYeUDJgnffz9ro+rgNGv1g@mail.gmail.com>
> On May 23, 2019, at 2:59 PM, Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
> what exactly is the issue with IP_TOS?
>
> If I understand correctly, the issue here is that the new 'P' option
> that polls on the error queue times out. This is unrelated to
> specifying TOS bits? Without zerocopy or timestamps, no message is
> expected on the error queue.
I was not able to get to the root cause, but I noticed that IP_TOS
CMSG was lost until I applied this fix. I also found it confusing as to
why that may be the case.
next prev parent reply other threads:[~2019-05-25 20:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 21:06 [PATCH net 0/4] Allow TX timestamp with UDP GSO Fred Klassen
2019-05-23 21:06 ` [PATCH net 1/4] net/udp_gso: " Fred Klassen
2019-05-23 21:39 ` Willem de Bruijn
2019-05-24 1:38 ` Fred Klassen
2019-05-24 4:53 ` Willem de Bruijn
2019-05-24 16:34 ` Fred Klassen
2019-05-24 19:29 ` Willem de Bruijn
2019-05-24 22:01 ` Fred Klassen
2019-05-25 15:20 ` Willem de Bruijn
2019-05-25 18:47 ` Fred Klassen
2019-05-27 1:30 ` Willem de Bruijn
2019-05-27 2:09 ` Willem de Bruijn
2019-05-25 20:46 ` Fred Klassen
2019-05-23 21:59 ` Willem de Bruijn
2019-05-25 20:09 ` Fred Klassen [this message]
2019-05-25 20:47 ` Fred Klassen
2019-05-23 21:06 ` [PATCH net 2/4] net/udpgso_bench_tx: options to exercise TX CMSG Fred Klassen
2019-05-23 21:45 ` Willem de Bruijn
2019-05-23 21:52 ` Willem de Bruijn
2019-05-24 2:10 ` Fred Klassen
2019-05-23 21:06 ` [PATCH net 3/4] net/udpgso_bench_tx: fix sendmmsg on unconnected socket Fred Klassen
2019-05-23 21:06 ` [PATCH net 4/4] net/udpgso_bench_tx: audit error queue Fred Klassen
2019-05-23 21:56 ` Willem de Bruijn
2019-05-24 1:27 ` Fred Klassen
2019-05-24 5:02 ` Willem de Bruijn
2019-05-27 21:30 ` Fred Klassen
2019-05-27 21:46 ` Willem de Bruijn
2019-05-27 22:56 ` Fred Klassen
2019-05-28 1:15 ` Willem de Bruijn
2019-05-28 5:19 ` Fred Klassen
2019-05-28 15:08 ` Willem de Bruijn
2019-05-28 16:57 ` Fred Klassen
2019-05-28 17:07 ` Willem de Bruijn
2019-05-28 17:11 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D37889F4-104C-4E9A-B5CB-A0FCCEFF2D93@appneta.com \
--to=fklassen@appneta.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).