From: "Zi Yan" <zi.yan@cs.rutgers.edu>
To: "Kirill A. Shutemov" <kirill@shutemov.name>,
"Peter Xu" <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Michal Hocko" <mhocko@suse.com>,
"Huang Ying" <ying.huang@intel.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"Konstantin Khlebnikov" <khlebnikov@yandex-team.ru>,
"Souptick Joarder" <jrdr.linux@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: hugepage: mark splitted page dirty when needed
Date: Tue, 04 Sep 2018 10:00:28 -0400 [thread overview]
Message-ID: <D3B32B41-61D5-47B3-B1FC-77B0F71ADA47@cs.rutgers.edu> (raw)
In-Reply-To: <20180904080115.o2zj4mlo7yzjdqfl@kshutemo-mobl1>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On 4 Sep 2018, at 4:01, Kirill A. Shutemov wrote:
> On Tue, Sep 04, 2018 at 03:55:10PM +0800, Peter Xu wrote:
>> When splitting a huge page, we should set all small pages as dirty if
>> the original huge page has the dirty bit set before. Otherwise we'll
>> lose the original dirty bit.
>
> We don't lose it. It got transfered to struct page flag:
>
> if (pmd_dirty(old_pmd))
> SetPageDirty(page);
>
Plus, when split_huge_page_to_list() splits a THP, its subroutine __split_huge_page()
propagates the dirty bit in the head page flag to all subpages in __split_huge_page_tail().
--
Best Regards
Yan Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 496 bytes --]
next prev parent reply other threads:[~2018-09-04 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 7:55 [PATCH] mm: hugepage: mark splitted page dirty when needed Peter Xu
2018-09-04 8:01 ` Kirill A. Shutemov
2018-09-04 14:00 ` Zi Yan [this message]
2018-09-05 7:30 ` Peter Xu
2018-09-05 12:49 ` Zi Yan
2018-09-06 11:43 ` Peter Xu
2018-09-05 12:55 ` Kirill A. Shutemov
2018-09-06 11:39 ` Peter Xu
2018-09-06 14:08 ` Kirill A. Shutemov
2018-09-07 4:35 ` Peter Xu
2018-09-07 17:54 ` Jerome Glisse
2018-09-10 4:07 ` Peter Xu
2018-09-06 14:17 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D3B32B41-61D5-47B3-B1FC-77B0F71ADA47@cs.rutgers.edu \
--to=zi.yan@cs.rutgers.edu \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=khlebnikov@yandex-team.ru \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peterx@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).