From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51946C49ED6 for ; Wed, 11 Sep 2019 17:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9735420863 for ; Wed, 11 Sep 2019 17:43:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="p997Yrb4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729703AbfIKRnZ (ORCPT ); Wed, 11 Sep 2019 13:43:25 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.20]:31312 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729483AbfIKRnZ (ORCPT ); Wed, 11 Sep 2019 13:43:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1568223799; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=I5N0mIKioyErN8ieKWZ34hwP3cp6hVAp8pMtpw+iaIU=; b=p997Yrb4h0KhQl1eH5uTi+i+OjN+jrab+fNCORvMd+WvEhzUhqGl34Fg8Uh+aboecQ pVgb6FZr6jmFosZVMBfCQ+o/17VMkYUES+ar3ppq1MqLjcdih6GkHNZMWnicsyUgf3tF Yu8IX2VzA2C6dhO/ZtK6EF37H4XYal6FPXXM9912c/gGmJ2tL/hhnDvS4zgxxIhpJYgz uzzweMaw3D9A8um51shwrF+I7OYRXzM/i7B+acA+ef5/qiGjn1tAbyVOihw0HMX3YJXu rsA/Hc2kReljX5sMaURPt13+PD0ym4fC4Q2AWMG3LeMFTWybQ/uf/qF3S88DjctnANKh hsKw== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/PgwDCvjo0=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 44.27.0 DYNA|AUTH) with ESMTPSA id u036f9v8BHhG8nG (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 11 Sep 2019 19:43:16 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [Letux-kernel] [RFC PATCH 0/3] Enable 1GHz support on omap36xx From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 11 Sep 2019 19:43:16 +0200 Cc: Nishanth Menon , Linux-OMAP , Tony Lindgren , Linux Kernel Mailing List , =?utf-8?Q?Andr=C3=A9_Roth?= , Discussions about the Letux Kernel Content-Transfer-Encoding: quoted-printable Message-Id: References: <0C1EF64E-B33C-4BFA-A7D3-471DD1B9EE86@goldelico.com> <515048DE-138D-4400-8168-F2B7D61F1005@goldelico.com> <7B3D1D77-3E8C-444F-90B9-6DF2641178B8@goldelico.com> <87420DBD-770F-4C32-9499-A3AEA5876E8A@goldelico.com> <20190909163236.GP52127@atomide.com> <3663B13C-1AAB-4BE3-8CAD-F821B70393FA@goldelico.com> <56482888-DBD3-4658-8DB9-FB57653B5AA8@goldelico.com> <285FED38-2B2B-4813-9FD2-396C53E9B1B2@goldelico.com> <65A23326-70B4-46E3-992D-74256B056900@goldelico.com> To: Adam Ford X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adam, > Am 11.09.2019 um 18:01 schrieb H. Nikolaus Schaller = : >=20 >>=20 >> Am 11.09.2019 um 17:56 schrieb Adam Ford : >>=20 >>> There are some subtleties for testing. >>>=20 >>> * I have added turbo-mode; to OPP6 / OPP1G >>> * which means they are available but not used by the ondemand = govenor >>> * to enable them one has to echo 1 = >/sys/devices/system/cpu/cpufreq/boost >>=20 >> Will that be documented somewhere? If not, can we put a comment in = the >> device tree so people know how to enable it? >=20 > It seems to be pretty standard on i86 systems if you google for "turbo = mode". > I have added it to the commit message which adds the vbb regulator. And, I am not sure if DT maintainers will accept comments about the Linux /sys implementation in device tree files or bindings. Those should be independent of Linux. Basically the turbo-mode property is a hint to the OPP system (which may or may not use of it). So I think it is indeed better to have it in the commit message and not the code. One more thought: as long as we do not have junction temperature = monitoring we should keep it off by default... We may even remove the turbo-mode designator if we have the 90=C2=B0C limit and smart reflex working. BR, Nikolaus