From: Oleg Drokin <green@linuxhacker.ru>
To: Al Viro <viro@ZenIV.linux.org.uk>,
Trond Myklebust <trond.myklebust@primarydata.com>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
linux-nfs@vger.kernel.org,
"<linux-kernel@vger.kernel.org> Mailing List"
<linux-kernel@vger.kernel.org>,
"<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>
Subject: Re: NFS/d_splice_alias breakage
Date: Mon, 20 Jun 2016 09:25:12 -0400 [thread overview]
Message-ID: <D500FB60-CE33-4655-9995-70332B5945D2@linuxhacker.ru> (raw)
In-Reply-To: <20160603055655.GQ14480@ZenIV.linux.org.uk>
It looks like this patch was totally forgotten?
I don't see it in neither vfs nor nfs trees and yet it fixes a very easy to cause
crash in nfs code. And I think it's unrelated to the other parallel case too.
On Jun 3, 2016, at 1:56 AM, Al Viro wrote:
> On Fri, Jun 03, 2016 at 12:58:10AM -0400, Oleg Drokin wrote:
>
>> This one cures the insta-crash I was having, and I see no other ill-effects so far.
>
> OK... I can take it through vfs.git, but I think it'd be better off in
> NFS tree. Is everyone OK with something like the following?
>
> make nfs_atomic_open() call d_drop() on all ->open_context() errors.
>
> In "NFSv4: Move dentry instantiation into the NFSv4-specific atomic open code"
> unconditional d_drop() after the ->open_context() had been removed. It had
> been correct for success cases (there ->open_context() itself had been doing
> dcache manipulations), but not for error ones. Only one of those (ENOENT)
> got a compensatory d_drop() added in that commit, but in fact it should've
> been done for all errors. As it is, the case of O_CREAT non-exclusive open
> on a hashed negative dentry racing with e.g. symlink creation from another
> client ended up with ->open_context() getting an error and proceeding to
> call nfs_lookup(). On a hashed dentry, which would've instantly triggered
> BUG_ON() in d_materialise_unique() (or, these days, its equivalent in
> d_splice_alias()).
>
> Cc: stable@vger.kernel.org # v3.10+
> Tested-by: Oleg Drokin <green@linuxhacker.ru>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index aaf7bd0..6e3a6f4 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -1536,9 +1536,9 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry,
> err = PTR_ERR(inode);
> trace_nfs_atomic_open_exit(dir, ctx, open_flags, err);
> put_nfs_open_context(ctx);
> + d_drop(dentry);
> switch (err) {
> case -ENOENT:
> - d_drop(dentry);
> d_add(dentry, NULL);
> nfs_set_verifier(dentry, nfs_save_change_attribute(dir));
> break;
next prev parent reply other threads:[~2016-06-20 13:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 22:46 NFS/d_splice_alias breakage Oleg Drokin
2016-06-02 23:59 ` [PATCH] Allow d_splice_alias to accept hashed dentries green
2016-06-03 0:25 ` Oleg Drokin
2016-06-03 0:44 ` NFS/d_splice_alias breakage Trond Myklebust
2016-06-03 0:54 ` Oleg Drokin
2016-06-03 3:26 ` Al Viro
2016-06-03 3:38 ` Al Viro
2016-06-03 3:28 ` Al Viro
2016-06-03 3:37 ` Al Viro
2016-06-03 3:43 ` Oleg Drokin
2016-06-03 4:26 ` Al Viro
2016-06-03 4:42 ` Al Viro
2016-06-03 4:53 ` Al Viro
2016-06-03 4:58 ` Oleg Drokin
2016-06-03 5:56 ` Al Viro
2016-06-06 23:36 ` Oleg Drokin
2016-06-10 1:33 ` Oleg Drokin
2016-06-10 16:49 ` Oleg Drokin
2016-06-20 13:25 ` Oleg Drokin [this message]
2016-06-20 14:08 ` Al Viro
2016-06-20 14:54 ` Trond Myklebust
2016-06-20 15:28 ` Al Viro
2016-06-20 15:43 ` Anna Schumaker
2016-06-20 15:45 ` Oleg Drokin
2016-06-20 15:47 ` Trond Myklebust
2016-06-03 16:38 ` Dcache oops Oleg Drokin
2016-06-03 18:22 ` Al Viro
2016-06-03 18:35 ` Oleg Drokin
2016-06-03 20:07 ` Al Viro
2016-06-03 21:17 ` Oleg Drokin
2016-06-03 21:46 ` Al Viro
2016-06-03 22:17 ` Al Viro
2016-06-03 21:18 ` Linus Torvalds
2016-06-03 21:26 ` Al Viro
2016-06-03 22:00 ` Linus Torvalds
2016-06-03 22:23 ` Al Viro
2016-06-03 22:29 ` Al Viro
2016-06-03 22:36 ` Linus Torvalds
2016-06-03 22:42 ` Oleg Drokin
2016-06-03 22:43 ` Al Viro
2016-06-03 22:37 ` Al Viro
2016-06-03 22:49 ` Oleg Drokin
2016-06-03 23:58 ` Oleg Drokin
2016-06-04 0:56 ` Al Viro
2016-06-04 12:25 ` Jeff Layton
2016-06-04 16:12 ` Oleg Drokin
2016-06-04 16:21 ` [PATCH] nfs4: Fix potential use after free of state in nfs4_do_reclaim green
2016-06-04 19:57 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D500FB60-CE33-4655-9995-70332B5945D2@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=bfields@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).