linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] max17042_battery: fix driver exit function
Date: Sat, 5 May 2012 04:42:30 +0000	[thread overview]
Message-ID: <D854C92F57B1B347B57E531E78D05EAD13FE77@BGSMSX102.gar.corp.intel.com> (raw)
In-Reply-To: <20120505023620.GB812@lizard>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 981 bytes --]

> On Tue, Apr 10, 2012 at 05:20:33AM +0000, Pallala, Ramakrishna wrote:
> [...]
> > >  	power_supply_unregister(&chip->battery);
> > > +	if (client->irq)
> > > +		free_irq(client->irq, chip);
> > > +	i2c_set_clientdata(client, NULL);
> > > +
> > >  	return 0;
> > >  }
> >
> > I have not received any comments for this patch.
> > Can I assume that this patch is in your merge queue?
> 
> Applied, but I removed i2c_set_clientdata(client, NULL) line in this patch. It is not be
> required nowadays, I2C core does it by itself.
> 
> Plus, I changed the order of the calls: we should free irq first, then unregister the
> power supply (btw, you might want to fix probe function as well: it should request irq
> only after power supply object is fully usable).

Thanks for the fix. I will look into the probe().

Thanks,
Ram
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

      reply	other threads:[~2012-05-05  4:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 10:08 [PATCH] max17042_battery: fix driver exit function Ramakrishna Pallala
2012-04-10  5:20 ` Pallala, Ramakrishna
2012-05-05  2:36   ` Anton Vorontsov
2012-05-05  4:42     ` Pallala, Ramakrishna [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D854C92F57B1B347B57E531E78D05EAD13FE77@BGSMSX102.gar.corp.intel.com \
    --to=ramakrishna.pallala@intel.com \
    --cc=cbouatmailru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).