From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Michael Walle <michael@walle.cc>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Necip Fazil Yildiran <fazilyildiran@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 00/14] pinctrl: add BCM63XX pincontrol support
Date: Wed, 3 Mar 2021 17:23:20 +0100 [thread overview]
Message-ID: <D875EBA4-F881-4F1E-A251-78CEF8E6A40B@gmail.com> (raw)
In-Reply-To: <CACRpkdbi77SBsssMOnx43fP9RgqnzkUUw=TXaE2_LDexpE2WEg@mail.gmail.com>
Hi Linus,
> El 3 mar 2021, a las 16:29, Linus Walleij <linus.walleij@linaro.org> escribió:
>
> On Wed, Mar 3, 2021 at 3:23 PM Álvaro Fernández Rojas <noltari@gmail.com> wrote:
>
>> v3: introduce new files for shared code and add more changes suggested by
>> Linus Walleij. Also add a new patch needed for properly parsing gpio-ranges.
>
> This looks very appetizing, I am ready to merge this once we cut some
> slack for DT review (a week or two).
>
> I'd like to merge it soon so you can start working on the IRQ add-on.
>
> I'd probably drop the IRQ-related selects from Kconfig
> when applying though (no big deal, no need to resend over that).
About that, it seems that GPIO_REGMAP should select GPIOLIB_IRQCHIP, since I couldn’t build the kernel due to the following error when I removed the IRQ-related selects:
LD vmlinux.o
MODPOST vmlinux.symvers
MODINFO modules.builtin.modinfo
GEN modules.builtin
LD .tmp_vmlinux.kallsyms1
mips-linux-gnu-ld: drivers/gpio/gpio-regmap.o: in function `gpio_regmap_register':
gpio-regmap.c:(.text+0x704): undefined reference to `gpiochip_irqchip_add_domain'
make: *** [Makefile:1197: vmlinux] Error 1
Or maybe we could guard these lines of gpio-regmap.c with #ifdef GPIOLIB_IRQCHIP:
https://github.com/torvalds/linux/blob/f69d02e37a85645aa90d18cacfff36dba370f797/drivers/gpio/gpio-regmap.c#L282-L286
>
> Yours,
> Linus Walleij
Best regards,
Álvaro.
next prev parent reply other threads:[~2021-03-03 19:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 14:22 [PATCH v3 00/14] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-03-03 14:22 ` [PATCH v3 01/14] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas
2021-03-03 15:27 ` Linus Walleij
2021-03-03 15:39 ` Michael Walle
2021-03-03 16:08 ` Michael Walle
2021-03-03 16:12 ` Álvaro Fernández Rojas
2021-03-04 8:13 ` Linus Walleij
2021-03-04 8:27 ` Álvaro Fernández Rojas
2021-03-03 14:22 ` [PATCH v3 02/14] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas
2021-03-03 14:22 ` [PATCH v3 03/14] Documentation: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 04/14] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 05/14] Documentation: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 06/14] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 07/14] Documentation: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 08/14] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 09/14] Documentation: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 10/14] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 11/14] Documentation: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 12/14] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 13/14] Documentation: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-03 14:23 ` [PATCH v3 14/14] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas
2021-03-03 15:29 ` [PATCH v3 00/14] pinctrl: add BCM63XX pincontrol support Linus Walleij
2021-03-03 16:23 ` Álvaro Fernández Rojas [this message]
2021-03-04 0:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D875EBA4-F881-4F1E-A251-78CEF8E6A40B@gmail.com \
--to=noltari@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fazilyildiran@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).