From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758951AbdJQXED convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 19:04:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:22614 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755112AbdJQXEC (ORCPT ); Tue, 17 Oct 2017 19:04:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,392,1503385200"; d="scan'208";a="161633356" From: "Dilger, Andreas" To: "Gustavo A. R. Silva" CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs Thread-Topic: [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs Thread-Index: AQHTQ3WrJdQ/DOOxgkaUbbTpV/t0tqLpJtuA Date: Tue, 17 Oct 2017 23:04:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.142.85] Content-Type: text/plain; charset="us-ascii" Content-ID: <0B733E35B5B2874A8098A75D4364A080@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > index aad4ff1..a3664c1 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > @@ -786,7 +786,7 @@ __u32 lustre_msg_get_flags(struct lustre_msg *msg) > > CERROR("invalid msg %p: no ptlrpc body!\n", msg); > } > - /* no break */ > + /* fall through */ > default: > /* flags might be printed in debug code while message > * uninitialized > @@ -854,7 +854,7 @@ __u32 lustre_msg_get_op_flags(struct lustre_msg *msg) > > CERROR("invalid msg %p: no ptlrpc body!\n", msg); > } > - /* no break */ > + /* fall through */ > default: > return 0; > } > @@ -1035,7 +1035,7 @@ int lustre_msg_get_status(struct lustre_msg *msg) > > CERROR("invalid msg %p: no ptlrpc body!\n", msg); > } > - /* no break */ > + /* fall through */ > default: > /* status might be printed in debug code while message > * uninitialized > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation