From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>,
git-packagers@googlegroups.com
Subject: Re: [ANNOUNCE] Git v2.27.0-rc2
Date: Thu, 28 May 2020 18:24:45 +0530 [thread overview]
Message-ID: <DA3387FB-670A-4A36-9017-6D1372F9DBC2@gmail.com> (raw)
In-Reply-To: <xmqqa71tmika.fsf@gitster.c.googlers.com>
On 27 May 2020 22:17:01 GMT+05:30, Junio C Hamano <gitster@pobox.com> wrote:
>Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
>
>> Hi Junio,
>>
>> On 27-05-2020 00:17, Junio C Hamano wrote:
>>> Shourya Shukla (4):
>>> submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
>>> gitfaq: files in .gitignore are tracked
>>> gitfaq: fetching and pulling a repository
>>> submodule: port subcommand 'set-url' from shell to C
>>
>> This is the only place where the `set-url` conversion from Shell to C
>> is mentioned. I wonder if it's enough or if it needs a little bit
>more
>> attention may be in the "Performance, Internal Implementation,
>> Development Support etc." as it is a conversion of a submodule
>> sub-command?
>
>I'm not sure if it is worth the bits. It may matter _only_ if/when
>new implementaiton of set-url hurts the end-users by being buggy ;-)
OK. That makes sense. The converted version has gone through reviews and presumably it does pass our CI test cases. I think I was just trying to overcautious to ensure we're not bitten by a worst case scenario wherein a bug slipped through the reviews and the tests. I believe it's pretty unlikely, though :-)
--
Sivaraam
Sent from my Android device with K-9 Mail. Please excuse my brevity and possible "typso".
next prev parent reply other threads:[~2020-05-28 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 18:47 [ANNOUNCE] Git v2.27.0-rc2 Junio C Hamano
2020-05-26 19:06 ` Kaartic Sivaraam
2020-05-27 16:47 ` Junio C Hamano
2020-05-28 12:54 ` Kaartic Sivaraam [this message]
2020-05-27 10:18 ` Pratyush Yadav
2020-05-27 16:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA3387FB-670A-4A36-9017-6D1372F9DBC2@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).