From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B099EC433F5 for ; Mon, 6 Sep 2021 07:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97CCA60200 for ; Mon, 6 Sep 2021 07:53:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240113AbhIFHyh (ORCPT ); Mon, 6 Sep 2021 03:54:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230466AbhIFHyg (ORCPT ); Mon, 6 Sep 2021 03:54:36 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 542F1C061757 for ; Mon, 6 Sep 2021 00:53:32 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id mw10-20020a17090b4d0a00b0017b59213831so3803708pjb.0 for ; Mon, 06 Sep 2021 00:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rlaLLiMPNdX6nNJMxLikoTvHO7/HZLWVppl3vRWfr5k=; b=BtRbsXztmfeZlr2eUdjZKt9p9ijpkUx2lzClwVoY2p+cL5DtkINv+VBUC5HA/0cC9U D+V/ARnbijw3EDe9D/Izm9eF4TSs48nFdOzd7Dzb0DRdEDzMvrilQT/45YqLDvI/KZm3 EKIZbEdYvh+6Q8g9b1LVCi46LqynSrdTq3gKN8T41M+M/8AHFRhEeMxhcpCke0jqb8hl HmprZ8o2b/bicn7KWMqYz2cIWuUquUsmouoVYz/0ODP0ca6tXyD6CKjaHIW9UiIxQ3iF bgGeWnoEIkP+G0lZh7l4+wWcJPj24POIMG/kb/ORG7yh4+pOOhUgnLL9Z/sW/Xn4row+ cddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rlaLLiMPNdX6nNJMxLikoTvHO7/HZLWVppl3vRWfr5k=; b=AywKAjT/qU9LR5z0DRLmfnyfqyms+Lsiq7UO7/ztBulL7u/rsTjyAI8dootjSaVA6Z Eb7pmuJ/gkS6NHKFeoYBKLkPFaii23tgXdopBbi9fsLuzJOJNL2hyay5jGjeHm6po73U UPwHMzkeIXiiiJmaiNWbkg6WUDaYP+HBG4MMhstv+ENjaAcAL302eNKuaGstp+vhjHCS pOg1l4SJjEioVHqDL2HHOeWJ35aZs5sk13JmI47mCCKlyuG4s16arj/jO5XUfKOIdCr9 uxqe8lno5nX6+BlpihkgDg37ja9Oy+WB8ISdZWeqGHGPRYljCaxdWrVrw6bqJ1O9OQso CGmQ== X-Gm-Message-State: AOAM531e0fw7CuizLs+PExUfsTAg8ekyBUZUgDG3Dsxc3JhXqDTEh/u+ vlzGvnGBsvuTHApFG+tocPkCtQ== X-Google-Smtp-Source: ABdhPJxa7VODnGLnMj+iLcEo8Wj2OTDHWE5rnzJIJ+Lx07zI/gpZnKfxGEBWVVe5i46jYcdr7xG+3g== X-Received: by 2002:a17:90b:105:: with SMTP id p5mr12902957pjz.183.1630914811820; Mon, 06 Sep 2021 00:53:31 -0700 (PDT) Received: from smtpclient.apple ([139.177.225.225]) by smtp.gmail.com with ESMTPSA id g11sm7027760pgn.41.2021.09.06.00.53.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Sep 2021 00:53:31 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: [PATCH] RDMA/rxe: Fix wrong port_cap_flags From: Junji Wei In-Reply-To: Date: Mon, 6 Sep 2021 15:53:26 +0800 Cc: Doug Ledford , Jason Gunthorpe , RDMA mailing list , LKML , xieyongji@bytedance.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210831083223.65797-1-weijunji@bytedance.com> To: Zhu Yanjun X-Mailer: Apple Mail (2.3654.80.0.2.43) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sep 6, 2021, at 3:21 PM, Zhu Yanjun wrote: >=20 > On Tue, Aug 31, 2021 at 4:32 PM Junji Wei = wrote: >>=20 >> The port->attr.port_cap_flags should be set to enum >> ib_port_capability_mask_bits in ib_mad.h, >> not RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP. >>=20 >> Signed-off-by: Junji Wei >> --- >> drivers/infiniband/sw/rxe/rxe_param.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/infiniband/sw/rxe/rxe_param.h = b/drivers/infiniband/sw/rxe/rxe_param.h >> index 742e6ec93686..b5a70cbe94aa 100644 >> --- a/drivers/infiniband/sw/rxe/rxe_param.h >> +++ b/drivers/infiniband/sw/rxe/rxe_param.h >> @@ -113,7 +113,7 @@ enum rxe_device_param { >> /* default/initial rxe port parameters */ >> enum rxe_port_param { >> RXE_PORT_GID_TBL_LEN =3D 1024, >> - RXE_PORT_PORT_CAP_FLAGS =3D = RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP, >> + RXE_PORT_PORT_CAP_FLAGS =3D IB_PORT_CM_SUP, >=20 > RXE_PORT_PORT_CAP_FLAGS =3D IB_PORT_CM_SUP | > RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP, >=20 > Is it better? >=20 > Zhu Yanjun I don=E2=80=99t think so. Because RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP(0x800000) means IB_PORT_BOOT_MGMT_SUP(1 << 23) in ib_mad.h. RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP should be used for port=E2=80=99s core_cap_flags. >=20 >> RXE_PORT_MAX_MSG_SZ =3D 0x800000, >> RXE_PORT_BAD_PKEY_CNTR =3D 0, >> RXE_PORT_QKEY_VIOL_CNTR =3D 0, >> -- >> 2.30.1 (Apple Git-130) >>=20