From: Anson Huang <anson.huang@nxp.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
Andy Duan <fugang.duan@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"swboyd@chromium.org" <swboyd@chromium.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message
Date: Sat, 12 Oct 2019 01:09:47 +0000 [thread overview]
Message-ID: <DB3PR0402MB391602D0860E8ADC2DB36475F5960@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CA+h21hpp5L-tcJNxXWaJaCKZyFzm-qPzUZ32LU+vKOv99PJ9ng@mail.gmail.com>
Hi, Vladimir
> On Fri, 11 Oct 2019 at 04:11, Anson Huang <anson.huang@nxp.com> wrote:
> >
> > Hi, Jakub
> >
> > > On Fri, 11 Oct 2019 00:38:50 +0000, Anson Huang wrote:
> > > > > Hm. Looks like the commit you need is commit f1da567f1dc1 ("driver
> core:
> > > > > platform: Add platform_get_irq_byname_optional()") and it's
> > > > > currently in Greg's tree. You have to wait for that commit to
> > > > > make its way into Linus'es main tree and then for Dave Miller to pull
> from Linus.
> > > > >
> > > > > I'd suggest you check if your patches builds on the net tree:
> > > > >
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> > > > >
> > > > > once a week. My guess is it'll probably take two weeks or so for
> > > > > Greg's patches to propagate to Dave.
> > > >
> > > > Thanks for explanation of how these trees work, so could you
> > > > please wait the necessary patch landing on network tree then apply
> > > > this patch series, thanks for help.
> > >
> > > Unfortunately the networking subsystem sees around a 100 patches
> > > submitted each day, it'd be very hard to keep track of patches which
> > > have external dependencies and when to merge them. That's why we
> > > need the submitters to do this work for us and resubmit when the
> > > patch can be applied cleanly.
> >
> > OK, I will resend this patch series once the necessary patch lands on
> > the network tree.
>
> What has not been mentioned is that you can't create future dependencies
> for patches which have a Fixes: tag.
>
> git describe --tags 7723f4c5ecdb # driver core: platform: Add an error
> message to platform_get_irq*() v5.3-rc1-13-g7723f4c5ecdb
>
> git describe --tags f1da567f1dc # driver core: platform: Add
> platform_get_irq_byname_optional()
> v5.4-rc1-46-gf1da567f1dc1
>
> So you have to consider whether the patch is really fixing anything (it is only
> getting rid of a non-fatal error message).
> And it's not reasonable anyway to say that you're fixing the patch that added
> the error message in the generic framework.
> The fallback logic has always been there in the driver. So you might want to
> drop the Fixes: tag when you resend.
OK, I agree that such kind of patch should NOT add fix tag, but I was confused when
I created this patch, as I saw many similar patches also has fix tag, such as below 2
examples.
I will drop the fix tag when resend the patch series.
commit 71eea7071583b04e9b796ee1d6f7a07334426495
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu Oct 10 11:15:20 2019 +0300
platform/x86: intel_punit_ipc: Avoid error message when retrieving IRQ
Since the commit
7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")
the platform_get_irq() started issuing an error message which is not
what we want here.
Switch to platform_get_irq_optional() to have only warning message
provided by the driver.
Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel_punit_ipc.c
commit 392fb8df528b97a06e19312772afd38aec542b96
Author: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Tue Oct 1 20:07:43 2019 +0200
serial: sh-sci: Use platform_get_irq_optional() for optional interrupts
As platform_get_irq() now prints an error when the interrupt does not
exist, scary warnings may be printed for optional interrupts:
sh-sci e6550000.serial: IRQ index 1 not found
sh-sci e6550000.serial: IRQ index 2 not found
sh-sci e6550000.serial: IRQ index 3 not found
sh-sci e6550000.serial: IRQ index 4 not found
sh-sci e6550000.serial: IRQ index 5 not found
Fix this by calling platform_get_irq_optional() instead for all but the
first interrupts, which are optional.
Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20191001180743.1041-1-geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c
thanks,
Anson
next prev parent reply other threads:[~2019-10-12 1:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 10:15 [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message Anson Huang
2019-10-09 10:15 ` [PATCH 2/2] net: fec_ptp: Use platform_get_irq_xxx_optional() " Anson Huang
2019-10-10 6:55 ` Andy Duan
2019-10-10 18:30 ` Stephen Boyd
2019-10-10 6:55 ` [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() " Andy Duan
2019-10-10 18:30 ` Stephen Boyd
2019-10-10 23:08 ` Jakub Kicinski
2019-10-11 0:03 ` Anson Huang
2019-10-11 0:32 ` Jakub Kicinski
2019-10-11 0:38 ` Anson Huang
2019-10-11 0:53 ` Jakub Kicinski
2019-10-11 1:10 ` Anson Huang
2019-10-11 9:55 ` Vladimir Oltean
2019-10-12 1:09 ` Anson Huang [this message]
2019-10-13 1:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB391602D0860E8ADC2DB36475F5960@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jakub.kicinski@netronome.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).