From: Anson Huang <anson.huang@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V2 1/3] dt-bindings: pinctrl: Convert i.MX8MQ to json-schema
Date: Wed, 15 Jan 2020 01:37:11 +0000 [thread overview]
Message-ID: <DB3PR0402MB391625FBD72C16E3C84ADCA7F5370@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200115001357.GA16961@bogus>
Hi, Rob
> Subject: Re: [PATCH V2 1/3] dt-bindings: pinctrl: Convert i.MX8MQ to json-
> schema
>
> On Fri, Jan 10, 2020 at 12:05:18PM +0800, Anson Huang wrote:
> > Convert the i.MX8MQ pinctrl binding to DT schema format using
> > json-schema
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > Changes since V1:
> > - use "grp$" instead of "-grp$";
> > - use space instead of tab for "ref$";
> > - add missed "reg" property;
> > - remove the "maxItem" for "fsl,pins" to avoid build warning, as the
> item number is changable.
> > ---
> > .../bindings/pinctrl/fsl,imx8mq-pinctrl.txt | 36 -----------
> > .../bindings/pinctrl/fsl,imx8mq-pinctrl.yaml | 69
> ++++++++++++++++++++++
> > 2 files changed, 69 insertions(+), 36 deletions(-) delete mode
> > 100644
> > Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt
> > create mode 100644
> > Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml
>
> Actually, it looks like you can combine all 3 into a single schema. The only diff
> is the compatible string.
The header files name, reference manual name and the examples are also different,
so, personally, I prefer to have them separately if no strong objection.
Thanks,
Anson
prev parent reply other threads:[~2020-01-15 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 4:05 [PATCH V2 1/3] dt-bindings: pinctrl: Convert i.MX8MQ to json-schema Anson Huang
2020-01-10 4:05 ` [PATCH V2 2/3] dt-bindings: pinctrl: Convert i.MX8MM " Anson Huang
2020-01-15 0:11 ` Rob Herring
2020-01-15 1:35 ` Anson Huang
2020-01-10 4:05 ` [PATCH V2 3/3] dt-bindings: pinctrl: Convert i.MX8MN " Anson Huang
2020-01-15 0:13 ` [PATCH V2 1/3] dt-bindings: pinctrl: Convert i.MX8MQ " Rob Herring
2020-01-15 1:37 ` Anson Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB391625FBD72C16E3C84ADCA7F5370@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).