LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Anson Huang <anson.huang@nxp.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V5 2/2] thermal: imx: save one condition block for normal case of nvmem initialization
Date: Fri, 7 Dec 2018 03:11:31 +0000
Message-ID: <DB3PR0402MB391626344F9D278D797B91CBF5AA0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <b28efba1-e04a-7e33-126b-b92c7aa5e9a9@linaro.org>

Gentle ping..

Best Regards!
Anson Huang

> -----Original Message-----
> From: Daniel Lezcano [mailto:daniel.lezcano@linaro.org]
> Sent: 2018年11月21日 16:31
> To: Anson Huang <anson.huang@nxp.com>; rui.zhang@intel.com;
> edubezval@gmail.com; linux-pm@vger.kernel.org;
> linux-kernel@vger.kernel.org; viresh.kumar@linaro.org;
> l.stach@pengutronix.de
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V5 2/2] thermal: imx: save one condition block for normal
> case of nvmem initialization
> 
> On 21/11/2018 06:49, Anson Huang wrote:
> > Put return value checks of calling imx_init_from_nvmem_cells() into
> > one block to save one condition block for normal case.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> > ---
> >  drivers/thermal/imx_thermal.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/imx_thermal.c
> > b/drivers/thermal/imx_thermal.c index c924396..bb6754a 100644
> > --- a/drivers/thermal/imx_thermal.c
> > +++ b/drivers/thermal/imx_thermal.c
> > @@ -742,9 +742,10 @@ static int imx_thermal_probe(struct
> > platform_device *pdev)
> >
> >  	if (of_find_property(pdev->dev.of_node, "nvmem-cells", NULL)) {
> >  		ret = imx_init_from_nvmem_cells(pdev);
> > -		if (ret == -EPROBE_DEFER)
> > -			return ret;
> >  		if (ret) {
> > +			if (ret == -EPROBE_DEFER)
> > +				return ret;
> > +
> >  			dev_err(&pdev->dev, "failed to init from nvmem: %d\n",
> >  				ret);
> >  			return ret;
> >
> 
> 
> --
> 
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .linaro.org%2F&amp;data=02%7C01%7Canson.huang%40nxp.com%7Cfd6043
> 7ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C636783858654973865&amp;sdata=BgscGAsKYemJsPxOeWnhK9o7
> 2DnyV%2B5p%2B%2F2FukhcpqM%3D&amp;reserved=0> Linaro.org │ Open
> source software for ARM SoCs
> 
> Follow Linaro:
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .facebook.com%2Fpages%2FLinaro&amp;data=02%7C01%7Canson.huang%40
> nxp.com%7Cfd60437ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92
> cd99c5c301635%7C0%7C0%7C636783858654973865&amp;sdata=6zA10lW
> wnWoAUK7jqqvsDDMM2Q13AedmeSPABMeR%2Bxc%3D&amp;reserved=0>
> Facebook |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitt
> er.com%2F%23!%2Flinaroorg&amp;data=02%7C01%7Canson.huang%40nxp.c
> om%7Cfd60437ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C0%7C636783858654973865&amp;sdata=kuquKEUuvXW
> 88V2QgPQgXYBgv2Htv37GKDqah0VeIJ8%3D&amp;reserved=0> Twitter |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .linaro.org%2Flinaro-blog%2F&amp;data=02%7C01%7Canson.huang%40nxp.c
> om%7Cfd60437ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C0%7C636783858654973865&amp;sdata=0AiYcj1H1va1n
> mee2tHWWYnmGe5wzFoao4KZbkxsKzo%3D&amp;reserved=0> Blog


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21  5:49 [PATCH V5 1/2] thermal: imx: fix for dependency on cpu-freq Anson Huang
2018-11-21  5:49 ` [PATCH V5 2/2] thermal: imx: save one condition block for normal case of nvmem initialization Anson Huang
2018-11-21  5:53   ` Viresh Kumar
2018-11-21  8:30   ` Daniel Lezcano
2018-12-07  3:11     ` Anson Huang [this message]
2018-11-21  5:53 ` [PATCH V5 1/2] thermal: imx: fix for dependency on cpu-freq Viresh Kumar
2018-11-21  8:30 ` Daniel Lezcano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0402MB391626344F9D278D797B91CBF5AA0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
    --to=anson.huang@nxp.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox