From: Anson Huang <anson.huang@nxp.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Stefan Agner <stefan.agner@toradex.com>,
"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Leo Li <leoyang.li@nxp.com>, Vinod Koul <vkoul@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Olof Johansson <olof@lixom.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 1/3] reset: imx7: Support module build
Date: Mon, 29 Jun 2020 11:32:22 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916ADD54CB167B8ED10076DF56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a0Za99-xXTwtHNHO-Dzbo-1uesNC2oO91RA-gZZG3Anmw@mail.gmail.com>
Hi, Arnd
> Subject: Re: [PATCH 1/3] reset: imx7: Support module build
>
> On Mon, Jun 29, 2020 at 12:45 PM Anson Huang <anson.huang@nxp.com>
> wrote:
> > > Subject: Re: [PATCH 1/3] reset: imx7: Support module build On Mon,
> > > Jun 29, 2020 at 12:25 PM Anson Huang <Anson.Huang@nxp.com> wrote:
> >
> > The reset driver normally won't be removed since it is necessary for
> > drivers which need it, it is just for Android GKI support, in this
> > case, do we need to change it to module_platform_driver()?
>
> Please at least try to do it, or explain in the changelog what went wrong if it
> doesn't work.
>
> I don't think "because Android GKI" should ever be the sole justification for a
> patch. Making drivers loadable module is a good idea regardless of GKI, and if
> you do that, then make it behave like any other loadable module.
>
OK, will do it in V2, BTW, I think there is nothing need to be done for .remove() callback,
can I just skip it or need to add a blank callback anyway?
Thanks,
Anson
next prev parent reply other threads:[~2020-06-29 20:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 10:13 [PATCH 1/3] reset: imx7: Support module build Anson Huang
2020-06-29 10:13 ` [PATCH 2/3] arm64: defconfig: Select CONFIG_RESET_IMX7 by default Anson Huang
2020-06-29 11:29 ` Arnd Bergmann
2020-06-29 11:34 ` Anson Huang
2020-06-29 11:53 ` Arnd Bergmann
2020-06-29 12:09 ` Anson Huang
2020-06-29 12:30 ` Arnd Bergmann
2020-06-29 12:46 ` Anson Huang
2020-06-29 12:55 ` Arnd Bergmann
2020-06-29 10:13 ` [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D Anson Huang
2020-06-29 11:31 ` Arnd Bergmann
2020-06-29 11:36 ` Anson Huang
2020-06-29 11:47 ` Arnd Bergmann
2020-06-29 11:54 ` Anson Huang
2020-06-29 12:02 ` Arnd Bergmann
2020-06-29 10:41 ` [PATCH 1/3] reset: imx7: Support module build Arnd Bergmann
2020-06-29 10:45 ` Anson Huang
2020-06-29 11:28 ` Arnd Bergmann
2020-06-29 11:32 ` Anson Huang [this message]
2020-06-29 11:41 ` Arnd Bergmann
2020-06-29 11:44 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916ADD54CB167B8ED10076DF56E0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=oleksandr.suvorov@toradex.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).