From: Anson Huang <anson.huang@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 3/3] watchdog: imx2_wdt: Remove unused include of init.h
Date: Sun, 23 Feb 2020 00:16:25 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916C4CC9A79BFA49441EBEAF5EF0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200222160218.GA12740@roeck-us.net>
Hi, Guenter
> Subject: Re: [PATCH 3/3] watchdog: imx2_wdt: Remove unused include of
> init.h
>
> On Fri, Feb 21, 2020 at 10:00:30AM +0800, Anson Huang wrote:
> > There is nothing in use from init.h, remove it.
> >
>
> NACK, sorry; this driver uses __init and __exit_p.
Ah, yes, just notice them. But I don't understand why the .probe callback needs
__init and .remove callback needs __exit_p? Should they need to be removed?
Thanks,
Anson
> Guenter
>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > drivers/watchdog/imx2_wdt.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> > index f8d58bf..ce28e40 100644
> > --- a/drivers/watchdog/imx2_wdt.c
> > +++ b/drivers/watchdog/imx2_wdt.c
> > @@ -20,7 +20,6 @@
> >
> > #include <linux/clk.h>
> > #include <linux/delay.h>
> > -#include <linux/init.h>
> > #include <linux/interrupt.h>
> > #include <linux/io.h>
> > #include <linux/kernel.h>
next prev parent reply other threads:[~2020-02-23 0:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 2:00 [PATCH 1/3] watchdog: imx_sc_wdt: Remove unused includes Anson Huang
2020-02-21 2:00 ` [PATCH 2/3] watchdog: imx7ulp: Remove unused include of init.h Anson Huang
2020-02-22 15:59 ` Guenter Roeck
2020-02-21 2:00 ` [PATCH 3/3] watchdog: imx2_wdt: " Anson Huang
2020-02-22 16:02 ` Guenter Roeck
2020-02-23 0:16 ` Anson Huang [this message]
2020-02-23 14:08 ` Guenter Roeck
2020-02-24 2:54 ` Anson Huang
2020-02-22 15:55 ` [PATCH 1/3] watchdog: imx_sc_wdt: Remove unused includes Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916C4CC9A79BFA49441EBEAF5EF0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).