From: Anson Huang <anson.huang@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
"linux@rempel-privat.de" <linux@rempel-privat.de>,
Peng Fan <peng.fan@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V5 1/2] dt-bindings: firmware: imx: Move system control into dt-binding headfile
Date: Mon, 27 Apr 2020 06:40:49 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916E21104F4D0DAF84A4B33F5AF0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200427061121.tsybnbqrzjpy7f3a@pengutronix.de>
Hi, Marco
> Subject: Re: [PATCH V5 1/2] dt-bindings: firmware: imx: Move system control
> into dt-binding headfile
>
> Hi Anson,
>
> sorry for jumping in..
>
> On 20-04-26 16:11, Anson Huang wrote:
> > From: Dong Aisheng <aisheng.dong@nxp.com>
> >
> > i.MX8 SoCs DTS file needs system control macro definitions, so move
> > them into dt-binding headfile, then include/linux/firmware/imx/types.h
> > can be removed and those drivers using it should be changed accordingly.
> >
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > Changes since V4:
> > - Use another patch for new added system controls and PM clock types.
> > ---
> > drivers/firmware/imx/imx-scu.c | 1 -
> > drivers/thermal/imx_sc_thermal.c | 2 +-
> > include/dt-bindings/firmware/imx/rsrc.h | 51
> ++++++++++++++++++++++++++
> > include/linux/firmware/imx/sci.h | 1 -
> > include/linux/firmware/imx/types.h | 65 ---------------------------------
> > 5 files changed, 52 insertions(+), 68 deletions(-) delete mode
> > 100644 include/linux/firmware/imx/types.h
> >
> > diff --git a/drivers/firmware/imx/imx-scu.c
> > b/drivers/firmware/imx/imx-scu.c index f71eaa5..f3340fa 100644
> > --- a/drivers/firmware/imx/imx-scu.c
> > +++ b/drivers/firmware/imx/imx-scu.c
> > @@ -8,7 +8,6 @@
> > */
> >
> > #include <linux/err.h>
> > -#include <linux/firmware/imx/types.h> #include
> > <linux/firmware/imx/ipc.h> #include <linux/firmware/imx/sci.h>
> > #include <linux/interrupt.h>
>
> You don't need this anymore here or was it a needless include?
I don't need this anymore, and since it is going to be removed, so this include also needs to be removed.
Thanks,
Anson
next prev parent reply other threads:[~2020-04-27 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 8:11 [PATCH V5 1/2] dt-bindings: firmware: imx: Move system control into dt-binding headfile Anson Huang
2020-04-26 8:11 ` [PATCH V5 2/2] dt-bindings: firmware: imx: Add more system controls and PM clock types Anson Huang
2020-04-27 6:11 ` [PATCH V5 1/2] dt-bindings: firmware: imx: Move system control into dt-binding headfile Marco Felsch
2020-04-27 6:40 ` Anson Huang [this message]
2020-05-13 8:20 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916E21104F4D0DAF84A4B33F5AF0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=m.felsch@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).