From: Anson Huang <anson.huang@nxp.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 2/2] firmware: imx: MU IRQ group number should be 7
Date: Fri, 24 Apr 2020 02:53:39 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916F906513074C97A8B4AA7F5D00@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM6PR04MB49668CCFFB4439B051E99A3B80D00@AM6PR04MB4966.eurprd04.prod.outlook.com>
> Subject: RE: [PATCH 2/2] firmware: imx: MU IRQ group number should be 7
>
> > From: Anson Huang <anson.huang@nxp.com>
> > Sent: Friday, April 24, 2020 10:36 AM
> >
> > > -----Original Message-----
> > > From: Aisheng Dong <aisheng.dong@nxp.com>
> > > Sent: 2020年4月24日 10:33
> > > To: Anson Huang <anson.huang@nxp.com>; shawnguo@kernel.org;
> > > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> > > ben.dooks@codethink.co.uk; linux-arm-kernel@lists.infradead.org;
> > > linux-kernel@vger.kernel.org
> > > Cc: dl-linux-imx <linux-imx@nxp.com>
> > > Subject: RE: [PATCH 2/2] firmware: imx: MU IRQ group number should
> > > be
> > > 7
> > >
> > > > From: Anson Huang <Anson.Huang@nxp.com>
> > > > Sent: Friday, April 24, 2020 7:07 AM
> > > >
> > > > The MU IRQ group number should be 7 instead of 4.
> > > >
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > >
> > > Are we using others IRQ group?
> > > If not, this change may slow down the irq handling speed.
> >
> > The irq handling is using work queue, NOT in ISR, so the speed is NOT
> > that sensitive.
>
> SCU IPC is shared by the whole system, each SCU transfer takes about 10~20
> us.
> Here you may waste 30~60us if not really used.
>
> > The scu group irq driver should provide full functions, as other
> > drivers using it may enable the group they want.
>
> Below are extra GROUPs you're going to add:
> #define SC_IRQ_GROUP_SYSCTR 4U /*!< System counter interrupts */
> #define SC_IRQ_GROUP_REBOOTED 5U /*!< Partition reboot complete
> */
> #define SC_IRQ_GROUP_REBOOT 6U /*!< Partition reboot starting */
> Are we really going to use it? It seems I also didn't see any users in
> downstream tree.
>
> Some functions provided by SCFW may not really used by Linux.
> I think I's better to add them when we really need them, otherwise we benefit
> nothing But wasting CPU mips.
I don't agree this, if SCFW NOT support it, it should fix from SCFW. This is aligned with our
internal tree.
Anson
next prev parent reply other threads:[~2020-04-24 2:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 23:07 [PATCH 1/2] firmware: imx: make sure MU irq can wake up system from suspend mode Anson Huang
2020-04-23 23:07 ` [PATCH 2/2] firmware: imx: MU IRQ group number should be 7 Anson Huang
2020-04-24 2:32 ` Aisheng Dong
2020-04-24 2:36 ` Anson Huang
2020-04-24 2:51 ` Aisheng Dong
2020-04-24 2:53 ` Anson Huang [this message]
2020-04-24 3:15 ` Aisheng Dong
2020-04-24 2:38 ` [PATCH 1/2] firmware: imx: make sure MU irq can wake up system from suspend mode Aisheng Dong
2020-05-28 1:54 ` Anson Huang
2020-06-17 13:48 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916F906513074C97A8B4AA7F5D00@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=ben.dooks@codethink.co.uk \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).