From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756120AbcK2JHw (ORCPT ); Tue, 29 Nov 2016 04:07:52 -0500 Received: from mail-db5eur01on0054.outbound.protection.outlook.com ([104.47.2.54]:54740 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753356AbcK2JHp (ORCPT ); Tue, 29 Nov 2016 04:07:45 -0500 From: =?iso-8859-2?Q?Horia_Geant=E3?= To: Herbert Xu , Stephen Rothwell CC: "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: linux-next: build failure after merge of the crypto tree Thread-Topic: linux-next: build failure after merge of the crypto tree Thread-Index: AQHSShfgX4/ZBafnrkm3AQMmU2HY/A== Date: Tue, 29 Nov 2016 08:34:08 +0000 Message-ID: References: <20161129115529.41f9f0b5@canb.auug.org.au> <20161129070840.GA5113@gondor.apana.org.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [192.88.146.1] x-ms-office365-filtering-correlation-id: ac91dcf5-a891-4c56-cdac-08d418327c98 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB4PR04MB0846; x-microsoft-exchange-diagnostics: 1;DB4PR04MB0846;7:pd8C6ZKTjctBQ5waw2eJMPjb8MY/1v9IcI1m2rE3CY98U6FxDWrr8YR+h3SeVsh9NPxN5o5TPGme/sNOpAKRw36OZOsqhBuI+U5mfoIpkBubfBXrZ1rmwbcacw09kfSOj1uRFb3jnYO4ANVqMpPjO8+yEnkEwDv15qxBvqkAMwx2eZnBRe/ZblB1tLNVYaoKq/Ej1djd08pD0YJm7fRjP9kgpG7ulrz3/GuxIdKPjvJBeg24O+T2S5QXqOPW9btu0caDpbvOoeP/mJ1eHkoW6I/II8gYk3LUHz4BEsxrfYR7jYxUC4/UDbfShFHczEgSOUT1k4MwZfqLKU6DC8+r7/+evLYDq3W7Jpp4Ap4w6jght9D85JGx3DctO9iS1YPHt0EAf4CoFnNykl9xFZOZQWgNCa1M0hCJltEq+B1skGlUv8WUG5SK0xbvxJhCrdZMh3x09Z4Bt4l8E8m8qGtJXA== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040361)(6060326)(6045199)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6061324)(6041248)(6046074)(20161123558021)(20161123564025)(20161123562025)(20161123560025)(20161123555025);SRVR:DB4PR04MB0846;BCL:0;PCL:0;RULEID:;SRVR:DB4PR04MB0846; x-forefront-prvs: 01415BB535 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(24454002)(189002)(199003)(377454003)(106356001)(74316002)(50986999)(76176999)(105586002)(106116001)(39380400001)(54356999)(39400400001)(39410400001)(2900100001)(66066001)(8936002)(122556002)(33656002)(68736007)(305945005)(39450400002)(77096006)(101416001)(3660700001)(97736004)(9686002)(92566002)(6116002)(3846002)(7736002)(4326007)(2906002)(575784001)(86362001)(7846002)(7696004)(229853002)(76576001)(3280700002)(8676002)(81156014)(38730400001)(5660300001)(81166006)(6506003)(5001770100001)(102836003)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR04MB0846;H:DB4PR04MB0847.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2016 08:34:08.0900 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0846 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAT97uYH031033 On 11/29/2016 10:09 AM, Herbert Xu wrote: > On Tue, Nov 29, 2016 at 11:55:29AM +1100, Stephen Rothwell wrote: >> Hi Herbert, >> >> After merging the crypto tree, today's linux-next build (arm >> multi_v7_defconfig) failed like this: >> >> ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-ce.ko] undefined! >> ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-ce.ko] undefined! >> ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-bs.ko] undefined! >> ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-bs.ko] undefined! >> >> Caused by commits >> >> da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher") >> 211f41af534a ("crypto: aesbs - Convert to skcipher") >> >> Missing dependencies? >> >> I have used the crypto tree from next-20161128 for today. > > Indeed. This patch should fix the problem. > > ---8<--- > Subject: crypto: arm/aes - Select SIMD in Kconfig > > The skcipher conversion for ARM missed the select on CRYPTO_SIMD, > causing build failures if SIMD was not otherwise enabled. > > Fixes: da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher") > Fixes: 211f41af534a ("crypto: aesbs - Convert to skcipher") The fix for this commit is missing. CRYPTO_AES_ARM_BS also needs to select CRYPTO_SIMD. > Reported-by: Stephen Rothwell > Signed-off-by: Herbert Xu > > diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig > index 27ed1b1..8134888 100644 > --- a/arch/arm/crypto/Kconfig > +++ b/arch/arm/crypto/Kconfig > @@ -105,7 +105,7 @@ config CRYPTO_AES_ARM_CE > tristate "Accelerated AES using ARMv8 Crypto Extensions" > depends on KERNEL_MODE_NEON > select CRYPTO_ALGAPI > - select CRYPTO_ABLK_HELPER > + select CRYPTO_SIMD > help > Use an implementation of AES in CBC, CTR and XTS modes that uses > ARMv8 Crypto Extensions > diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig > index 5f4a617..c5ce39c 100644 > --- a/arch/arm64/crypto/Kconfig > +++ b/arch/arm64/crypto/Kconfig > @@ -48,14 +48,14 @@ config CRYPTO_AES_ARM64_CE_BLK > depends on ARM64 && KERNEL_MODE_NEON > select CRYPTO_BLKCIPHER > select CRYPTO_AES_ARM64_CE > - select CRYPTO_ABLK_HELPER > + select CRYPTO_SIMD > > config CRYPTO_AES_ARM64_NEON_BLK > tristate "AES in ECB/CBC/CTR/XTS modes using NEON instructions" > depends on ARM64 && KERNEL_MODE_NEON > select CRYPTO_BLKCIPHER > select CRYPTO_AES > - select CRYPTO_ABLK_HELPER > + select CRYPTO_SIMD The commit message should also refer to: Fixes: d0ed0db149fce ("crypto: arm64/aes - Convert to skcipher") Horia