From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755953AbcIOUCK (ORCPT ); Thu, 15 Sep 2016 16:02:10 -0400 Received: from mail-db5eur01on0084.outbound.protection.outlook.com ([104.47.2.84]:58711 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751948AbcIOUB7 (ORCPT ); Thu, 15 Sep 2016 16:01:59 -0400 X-Greylist: delayed 17342 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Sep 2016 16:01:58 EDT From: Horia Geanta Neag To: SF Markus Elfring , "linux-crypto@vger.kernel.org" , "David S. Miller" , Herbert Xu , Labbe Corentin , Russell King CC: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall Subject: Re: crypto-caamhash: Fine-tuning for several function implementations Thread-Topic: crypto-caamhash: Fine-tuning for several function implementations Thread-Index: AQHSD16uwAUI2T+ewkGVlB+Vw4XhoQ== Date: Thu, 15 Sep 2016 15:30:04 +0000 Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <970e9e1b-c1dc-eb28-b380-92c15e9b1961@users.sourceforge.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [192.88.146.1] x-ms-office365-filtering-correlation-id: e9239306-772c-4972-c98f-08d3dd7d2a85 x-microsoft-exchange-diagnostics: 1;DB4PR04MB0846;6:l80Of6oTO81OKV2GWvnWDyjoIK0gqeWAHF8B23GVo3j+5bFsY1dlP+DhnxbznK7lc+J9i/RmVNhsfN8eJv0wNSNwlir9EWL+I6gvJoRSi1YHRl5bEA6Wu+8391vH4gneutou/bvNTCrBDxu8EAqH5yABb1AV7P4fkGCZteSeQ0MqwIxcQqIYdcBkDIWcZA72d8O04C1uRdf1tyq4I+mDIwAAEPAt3l+4C+zJGMwOXC9M2fhD7pLZ5qpAx//tdHDy347dnOJDuRiI5PHa9iYjQ3ZGHZ0ZBUZz93xpYDp93oNhKorpc0veb2D6Q+No2wACO0NexnqIEETLU+nJsq4Icw==;5:dlXKDZPefTiBst6agE7q6cUWGezxkTLz3J16bEfMbr/k2iYLz/iUeBTNurcPyV2QY2gG8d/kx5d4j2lmWAFruy9okAZtZTFY2dTUg5YNshSAbVDFXufZ94ac1plFfOF8pKm1flrwFf0ZgSYQvVwdtQ==;24:dRuOv8jfzJjLSgHpTHIpcCp3oYmmgC/h9gYCuB5MBt8ddEgdI1cGCmtyyCOIPx+qC/hS2kFR6GKECv+Vh5vLf/aUvB7kWOgQWTy8HDYMLBo=;7:VIxWD7EkyHdTf66DqJEh061dgRD0ce5Rja1xK84RN4rqeo033o1fM2tJ1PNiXDfCoyoJZzSEkNJWQ27Tj6Jrf7BM71eIwZkV8Z6LZNSCMt0UxVpG73/YWxNiWDGS0ZcdR/ehxWwQ/pFF1XXcdm9VPMk02NS35Ncm7JU0BiGzcA3wckM0/n8oG4i+hSLruOsXxd10/e9JmPQFn0YaVcuOUt8SSAKerk1TvGwpi2ZNRI3ipXRLSB6V0i1bOViDxKoI x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR04MB0846; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(42262312472803); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB4PR04MB0846;BCL:0;PCL:0;RULEID:;SRVR:DB4PR04MB0846; x-forefront-prvs: 0066D63CE6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(199003)(189002)(24454002)(3280700002)(68736007)(66066001)(3660700001)(10400500002)(2900100001)(19580405001)(19580395003)(33656002)(5001770100001)(97736004)(86362001)(9686002)(106116001)(4326007)(105586002)(102836003)(6116002)(3846002)(586003)(8936002)(122556002)(2501003)(92566002)(305945005)(101416001)(189998001)(76576001)(7736002)(7846002)(2906002)(81156014)(81166006)(74316002)(76176999)(54356999)(11100500001)(7696004)(106356001)(8676002)(87936001)(5002640100001)(50986999)(5660300001)(77096005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR04MB0846;H:DB4PR04MB0847.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2016 15:30:04.1932 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0846 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8FK2JMS008391 On 9/15/2016 5:37 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 15 Sep 2016 16:27:23 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (6): > Use kmalloc_array() in ahash_setkey() > Rename jump labels in ahash_setkey() > Rename a jump label in five functions > Return a value directly in caam_hash_cra_init() > Delete an unnecessary initialisation in seven functions > Move common error handling code in two functions > > drivers/crypto/caam/caamhash.c | 111 +++++++++++++++++++---------------------- > 1 file changed, 52 insertions(+), 59 deletions(-) > Thanks Markus! For patches 2-6: Reviewed-by: Horia Geantã though headline prefix should be changed to "crypto: caam -" Horia