From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760323AbcBYJkk (ORCPT ); Thu, 25 Feb 2016 04:40:40 -0500 Received: from mail-am1on0081.outbound.protection.outlook.com ([157.56.112.81]:5632 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759479AbcBYJkg convert rfc822-to-8bit (ORCPT ); Thu, 25 Feb 2016 04:40:36 -0500 X-Greylist: delayed 5590 seconds by postgrey-1.27 at vger.kernel.org; Thu, 25 Feb 2016 04:40:36 EST From: Yunhui Cui To: Han Xu , Yunhui Cui CC: "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "han.xu@freescale.com" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Yao Yuan Subject: RE: [PATCH v2 3/4] mtd:spi-nor:fsl-quadspi:Add fast-read mode support Thread-Topic: [PATCH v2 3/4] mtd:spi-nor:fsl-quadspi:Add fast-read mode support Thread-Index: AQHRXOWrZTSlU9UhfkK8SRcZW35KvJ8womQAgAvoNZA= Date: Thu, 25 Feb 2016 08:07:22 +0000 Message-ID: References: <1454326208-4533-1-git-send-email-B56489@freescale.com> <1454326208-4533-3-git-send-email-B56489@freescale.com> <20160217180742.GB17485@shlinux2> In-Reply-To: <20160217180742.GB17485@shlinux2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.158.241.86] x-microsoft-exchange-diagnostics: 1;DB3PR04MB0730;5:tvfqSLr5xBzcJWvrJdFJOFs+G/IudbBOWvGo4ekxKTyGFzpo3wK9J2njHJEfpWbYywOkgqt8AYzPQ8oetC5Qk/tlp1e0xpH5f6BwtpgBGdhp10lKmGjW95drEmRNJodxE0CKtha8WEQjl0lu1tzUrA==;24:taSBpBxZtH91eM5jjZwlu41KPJgkBmtS+F4HisMO6Tqt6+kCOycF9MbaeO6KXLYvhNlYmwiolnu5HRn0dzVoPY+WvCyQiHJI1tgUkASuMLg= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR04MB0730; x-ms-office365-filtering-correlation-id: 1ad6906e-a7d5-4818-9e9a-08d33dbab0e7 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DB3PR04MB0730;BCL:0;PCL:0;RULEID:;SRVR:DB3PR04MB0730; x-forefront-prvs: 08635C03D4 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(13464003)(377454003)(24454002)(586003)(66066001)(3846002)(6116002)(33656002)(10400500002)(5008740100001)(1096002)(102836003)(5004730100002)(92566002)(74316001)(2900100001)(5002640100001)(2906002)(2950100001)(1220700001)(189998001)(77096005)(5003600100002)(15975445007)(19580395003)(5001960100002)(19580405001)(106116001)(40100003)(87936001)(122556002)(11100500001)(5001770100001)(3280700002)(76176999)(50986999)(86362001)(4326007)(3660700001)(54356999)(76576001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR04MB0730;H:DB5PR0401MB1912.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2016 08:07:22.7427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR04MB0730 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Han, I have provided the options " m25p,fast-read ", because there are probable some flashes can't support quad mode. So we should support fast-read mode in our driver. Moreover, There is a option to select fast-read mode in spi_nor.c : /* If we were instantiated by DT, use it */ if (of_property_read_bool(np, "m25p,fast-read")) nor->flash_read = SPI_NOR_FAST; Thanks Yunhui -----Original Message----- From: Han Xu [mailto:xhnjupt@gmail.com] Sent: Thursday, February 18, 2016 2:08 AM To: Yunhui Cui Cc: dwmw2@infradead.org; computersforpeace@gmail.com; han.xu@freescale.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Yao Yuan Subject: Re: [PATCH v2 3/4] mtd:spi-nor:fsl-quadspi:Add fast-read mode support On Mon, Feb 01, 2016 at 07:30:07PM +0800, Yunhui Cui wrote: > The qspi driver add generic fast-read mode for different flash > venders. There are some different board flash work on different mode, > such fast-read, quad-mode. > So we have to modify the third entrace parameter of spi_nor_scan(). > > Signed-off-by: Yunhui Cui > --- > drivers/mtd/spi-nor/fsl-quadspi.c | 27 +++++++++++++++++++++------ > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c > b/drivers/mtd/spi-nor/fsl-quadspi.c > index 9861290..0a31cb1 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -389,11 +389,21 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q) > /* Read */ > lut_base = SEQID_READ * 4; > > - qspi_writel(q, LUT0(CMD, PAD1, read_op) | LUT1(ADDR, PAD1, addrlen), > - base + QUADSPI_LUT(lut_base)); > - qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > - LUT1(FSL_READ, PAD4, rxfifo), > - base + QUADSPI_LUT(lut_base + 1)); > + if (nor->flash_read == SPI_NOR_FAST) { > + qspi_writel(q, LUT0(CMD, PAD1, read_op) | > + LUT1(ADDR, PAD1, addrlen), > + base + QUADSPI_LUT(lut_base)); > + qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > + LUT1(FSL_READ, PAD1, rxfifo), > + base + QUADSPI_LUT(lut_base + 1)); > + } else if (nor->flash_read == SPI_NOR_QUAD) { > + qspi_writel(q, LUT0(CMD, PAD1, read_op) | > + LUT1(ADDR, PAD1, addrlen), > + base + QUADSPI_LUT(lut_base)); > + qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) | > + LUT1(FSL_READ, PAD4, rxfifo), > + base + QUADSPI_LUT(lut_base + 1)); > + } > > /* Write enable */ > lut_base = SEQID_WREN * 4; > @@ -468,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, > u8 cmd) { > switch (cmd) { > case SPINOR_OP_READ_1_1_4: > + case SPINOR_OP_READ_FAST: > return SEQID_READ; > case SPINOR_OP_WREN: > return SEQID_WREN; > @@ -963,6 +974,7 @@ static int fsl_qspi_probe(struct platform_device *pdev) > struct spi_nor *nor; > struct mtd_info *mtd; > int ret, i = 0; > + enum read_mode mode = SPI_NOR_QUAD; > > q = devm_kzalloc(dev, sizeof(*q), GFP_KERNEL); > if (!q) > @@ -1064,7 +1076,10 @@ static int fsl_qspi_probe(struct platform_device *pdev) > /* set the chip address for READID */ > fsl_qspi_set_base_addr(q, nor); > > - ret = spi_nor_scan(nor, NULL, SPI_NOR_QUAD); > + ret = of_property_read_bool(np, "m25p,fast-read"); > + mode = (ret) ? SPI_NOR_FAST : SPI_NOR_QUAD; > + > + ret = spi_nor_scan(nor, NULL, mode); > if (ret) > goto mutex_failed; > I understand you want to provide a more generic read mode, but this is a quad spi driver, I prefer to provide the options, either quad read/quad IO read, or just normal read. > -- > 2.1.0.27.g96db324 > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/