From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754834AbcIIMcR (ORCPT ); Fri, 9 Sep 2016 08:32:17 -0400 Received: from mail-db5eur01on0083.outbound.protection.outlook.com ([104.47.2.83]:8928 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752603AbcIIMcP (ORCPT ); Fri, 9 Sep 2016 08:32:15 -0400 From: "S.H. Xie" To: Marc Zyngier , "shh.xie@gmail.com" , "devicetree@vger.kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux-arm-kernel@lists.infradead.org" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "shawnguo@kernel.org" , "linux-kernel@vger.kernel.org" CC: Mihai Emilian Bantea , "C.H. Zhao" , "arnd@arndb.de" , "Z.Q. Hou" , "M.H. Lian" , Vincent Hu , Horia Geanta Neag , "Q.Y. Gong" Subject: RE: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support Thread-Topic: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support Thread-Index: AQHSB15qtQrbpcpS5kasgZ0Wj8lByqBvmZ6AgAFFGBA= Date: Fri, 9 Sep 2016 09:00:26 +0000 Message-ID: References: <1473069695-33092-1-git-send-email-shh.xie@gmail.com> <1473069695-33092-4-git-send-email-shh.xie@gmail.com> <57D1664D.3060502@arm.com> In-Reply-To: <57D1664D.3060502@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shaohui.xie@nxp.com; x-originating-ip: [199.59.230.102] x-ms-office365-filtering-correlation-id: 2ed92c73-a43d-484c-2a0e-08d3d88fbd93 x-microsoft-exchange-diagnostics: 1;DB5PR04MB1447;6:s5KjfsDtFs3yQp8LGzj6m4kRS3lN3M4Z+Z6Ff3iRMQpC3ojUJ57IqDzHR1rMjvgeFgzQuFAleRXYsUDuJV+8MjTiVh3uOIVwFj/2lGSXkx0qclodTgbJoDaKg8OopjOHkc7RnZj2Tu5OysSUCxJeNl6MiUNxjai2TYMUdfTuOZ5zfknOz04WnC0jGxfgSE4945Xwfbf7eclHAwY0h9PeyiALJQWQsHhmvtYdRVWlcgKHXrf353728+5X0yikE3Zf8nfFYH1vZOL+cPLlyXrDOpL1MzWh3s0c9+nfvv4KQJvPxc2sU0FkdsqJTIK8Bt6rn6zKW0PTYnQl+IT57t3UtA==;5:Wh3ZALBLPGeOZAuq3QTMGeIk/AqAyB205S6Yy+jfvocmVMvGAcHyx9qvMx/0f2pceh1mmX1pQ7+CFv+1VUU12jIiJdq5vNWxaXRlfS8P+JcqUzh3GV2eHQHIB5vXhHkgQ/C88QmcntiR8y7J94fm9Q==;24:u7RTEX5O5ijhlkDaNJjfwmfTcHTqj5WLYCucAzPZSXOSeX8xnmt4GcLJeA3vt8GswOzfuIZFHXSCnxJCQ1OSNtvEExRxkI3kQtag+0YlnjM=;7:2JnULArNbRPKJIoJhZTOG1Z2m72EPTiBJlJ2bQGny0cJ7ahBpgAE9KqESDkRcQ0OWlVThh+mFw6mtSIchLgr4eX0x1+6u2mZLacrqIFqT9RvwQcTuZWA4U36hzXblAHNQnEeQL9WGM9jos+gKC/RyfVSpMamzm6Fw6diguUcigBM5wMIHV7Rk6BjzI2XmWs7pzrbTyORgmGnnXZPSOAXa0zTCH2qn0r92hyNtnQWuY/kH+VSG69Z0Pjlo1Cfxy1p x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1447; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB5PR04MB1447;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1447; x-forefront-prvs: 00603B7EEF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(199003)(189002)(92566002)(54356999)(2950100001)(189998001)(2900100001)(66066001)(74316002)(5660300001)(2906002)(4326007)(105586002)(2501003)(3660700001)(2201001)(3280700002)(11100500001)(50986999)(97736004)(101416001)(76176999)(5002640100001)(3846002)(7696004)(81156014)(81166006)(8676002)(76576001)(5001770100001)(122556002)(33656002)(7416002)(77096005)(86362001)(586003)(87936001)(6116002)(7846002)(305945005)(19580405001)(102836003)(8936002)(7736002)(9686002)(10400500002)(106116001)(106356001)(68736007)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR04MB1447;H:DB5PR0401MB2183.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2016 09:00:26.0532 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1447 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u89CWMda032186 > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = , > > + , > > + , > > + ; > > No, this is completely wrong. The timer is always level triggered, and you're > missing the affinity bits that are described the GIC binding. [S.H] Will use (GIC_CPU_MASK_RAW(0xf) | IRQ_TYPE_LEVEL_LOW) in next version. > > > + }; > > + > > + pmu { > > + compatible = "arm,armv8-pmuv3"; > > Please add "arm,cortex-a72-pmu". [S.H] Will use "arm,cortex-a72-pmu" in next version. > > > + interrupts = , > > + , > > + , > > + ; > > + interrupt-affinity = <&cpu0>, > > + <&cpu1>, > > + <&cpu2>, > > + <&cpu3>; > > + }; > > + > > + gic: interrupt-controller@1400000 { > > + compatible = "arm,gic-400"; > > + #interrupt-cells = <3>; > > + interrupt-controller; > > + reg = <0x0 0x1410000 0 0x10000>, /* GICD */ > > + <0x0 0x1420000 0 0x20000>, /* GICC */ > > + <0x0 0x1440000 0 0x20000>, /* GICH */ > > + <0x0 0x1460000 0 0x20000>; /* GICV */ > > + interrupts = <1 9 0xf08>; > > Please choose between expressing the interrupts entirely with numerals or entirely > with symbols. At the moment this is a mix between the two. [S.H] Will fix it in next version. Thank you! Shaohui