From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1170321AbdDXN47 (ORCPT ); Mon, 24 Apr 2017 09:56:59 -0400 Received: from mx0a-00176a03.pphosted.com ([67.231.149.52]:41489 "EHLO mx0a-00176a03.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1170237AbdDXN45 (ORCPT ); Mon, 24 Apr 2017 09:56:57 -0400 From: "Han, Nandor (GE Healthcare)" To: Linus Walleij CC: Greg KH , "David S. Miller" , Geert Uytterhoeven , "Mauro Carvalho Chehab" , Daniel Vetter , Alexandre Courbot , Rob Herring , Mark Rutland , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Malinen, Semi (GE Healthcare)" Thread-Topic: Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver Thread-Index: AQHStECpmWCcTGKfS0C2cxm8pyKVN6HUmggAgAABVWA= Date: Mon, 24 Apr 2017 13:53:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=ge.com; x-originating-ip: [205.173.90.187] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6P101MB0247;7:6PUBT6Qd3ZPFEKUdhFNOuCQXATI0tHxPBfcjIKF7L9lTZB7NTXRvNn1SMh3hXsC9lfVV6V00yh4HlesFNN2WMd7tClYXniWvcakVn7AUuyyYrg4KPNuMTvGGWwJKJyQTVAUoqybSHrAEfqs86Xww6HpCGYGQlbErQFIPOQzZ94v2q/LLcJeev8LcHrkhKIgPF1JlTTqPnjAj9/9wE3jzmsRvPE/BvGKKzUmfyIO8b1debP0Z4RbEX37/fEv/Xcw61QDiulRzj5ZxGybghhg7iELjjsZDMy0nd+h3ab5uzUU5qk3kOFn7i9A2KerMF+UUudfU47rcwlOMv2chv/bklw== x-ld-processed: 15ccb6d1-d335-4996-b6f9-7b6925f08121,ExtAddr x-ms-office365-filtering-correlation-id: a5c130a6-16c3-4dad-768f-08d48b1941b1 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075);SRVR:DB6P101MB0247; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(9452136761055)(106981052589767); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:DB6P101MB0247;BCL:0;PCL:0;RULEID:;SRVR:DB6P101MB0247; x-forefront-prvs: 0287BBA78D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39450400003)(39850400002)(39400400002)(39410400002)(39860400002)(377454003)(13464003)(24454002)(54906002)(55016002)(5660300001)(9686003)(6246003)(110136004)(38730400002)(53546009)(6506006)(53936002)(33656002)(6436002)(4326008)(8676002)(2906002)(3660700001)(7416002)(122556002)(81166006)(3280700002)(2900100001)(102836003)(6916009)(86362001)(6116002)(189998001)(3846002)(39060400002)(305945005)(7696004)(74316002)(2950100002)(66066001)(50986999)(76176999)(54356999)(7736002)(8936002)(229853002)(25786009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6P101MB0247;H:DB6P101MB0246.NAMP101.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2017 13:53:15.7268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 15ccb6d1-d335-4996-b6f9-7b6925f08121 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P101MB0247 X-OriginatorOrg: ge.com Subject: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-24_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704240244 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3ODwwWh012956 > -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@linaro.org] > Sent: 24 April 2017 16:47 > To: Han, Nandor (GE Healthcare) > Cc: Greg KH ; David S. Miller ; Geert Uytterhoeven m68k.org>; Mauro Carvalho Chehab ; Daniel Vetter ; Alexandre Courbot > ; Rob Herring ; Mark Rutland ; linux- > gpio@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Malinen, Semi (GE Healthcare) > > Subject: EXT: Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver > > On Thu, Apr 13, 2017 at 12:27 PM, Nandor Han wrote: > > > This is a simple driver that provides a /sys/class/gpio > > interface for controlling and configuring the GPIO lines. > > It does not provide support for chip select or interrupts. > > > > Signed-off-by: Nandor Han > > Signed-off-by: Semi Malinen > > I almost want to make the driver depend on !GPIO_SYSFS because > of this commit message. > > DO NOT USE OR ENCOURAGE THE USE OF THE GPIO SYSFS > INTERFACE. > Ahh.. I forgot to change this commit message. Sorry I will change it ASAP. > Use the character device. > > Use the example in tools/gpio/* as a guideline and testbed. > > Use libgpiod as a rich userspace. > > And the commit message should state that this is a driver > for such and such Exar hardware instead. > > Thanks. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > You are missing > #include > > and that is why the build robot is complaining. > I've noticed that. I will change it in the next rev. > Yours, > Linus Walleij Thanks, Nandy