From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932431AbcKHGuC (ORCPT ); Tue, 8 Nov 2016 01:50:02 -0500 Received: from mail-db5eur01on0076.outbound.protection.outlook.com ([104.47.2.76]:38736 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752973AbcKHGt6 (ORCPT ); Tue, 8 Nov 2016 01:49:58 -0500 From: "Y.B. Lu" To: Arnd Bergmann CC: "linuxppc-dev@lists.ozlabs.org" , "linux-mmc@vger.kernel.org" , "ulf.hansson@linaro.org" , Scott Wood , Mark Rutland , Greg Kroah-Hartman , "X.B. Xie" , "M.H. Lian" , "linux-i2c@vger.kernel.org" , "linux-clk@vger.kernel.org" , Qiang Zhao , Russell King , Bhupesh Sharma , Joerg Roedel , Claudiu Manoil , "devicetree@vger.kernel.org" , Rob Herring , "Santosh Shilimkar" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , "iommu@lists.linux-foundation.org" , "Kumar Gala" Subject: RE: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl Thread-Topic: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl Thread-Index: AQHSMOlmXxQYUu6DxUudxg8Inz+GsKC9sQAAgASfnLCAC8cLAIAAngWA Date: Tue, 8 Nov 2016 06:49:51 +0000 Message-ID: References: <1477637418-38938-1-git-send-email-yangbo.lu@nxp.com> <2723366.1bJeJ7SKI6@wuerfel> <1543282.vWjeo4ynTa@wuerfel> In-Reply-To: <1543282.vWjeo4ynTa@wuerfel> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yangbo.lu@nxp.com; x-originating-ip: [192.158.241.86] x-ms-office365-filtering-correlation-id: f63824fe-a269-4305-7ce3-08d407a37074 x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2422;7:v9hV6XUycbqzXk//BPcGc67ik1b9o+eT7bvdS6xstPtz+1sdpGiZbEEQWqjROxeHVGMbG43GU5eVx+D1R13qCt3j00cXbIbTdb75C5YtYI1UCV8WwK2Tqj5XZx/kUnBqstdhsEhJOpAdg1+gdGCXg+ButAjgZAiDA5zkEic6buosZsgDBZwUZU3vWJ+5VPXVPfwt3697Qdr+8FWa5xpa/GE0tbaeuOKb7O+oGwoAXOSUm6umU81JPZ0WwTRToCXPCAN2zr08x7cJeY+mfcrcu5IheFXpVTPaZWHDwHQGfxOKwH9oLZhcoJbt8IkhOYSjIVNM0DxYiwkS4BHTr9oJLwhGPWrKU6HPs+uzq+eHpGI= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2422; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(6060229)(6045074)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6046074)(6061226);SRVR:DB6PR0401MB2422;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2422; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(189002)(199003)(13464003)(24454002)(33656002)(3660700001)(2900100001)(74316002)(87936001)(7736002)(92566002)(2950100002)(2906002)(6916009)(93886004)(4326007)(122556002)(3280700002)(9686002)(76176999)(189998001)(101416001)(106356001)(76576001)(50986999)(54356999)(102836003)(77096005)(3846002)(6116002)(68736007)(586003)(110136003)(97736004)(86362001)(7416002)(5660300001)(8936002)(105586002)(106116001)(7696004)(7846002)(81166006)(66066001)(81156014)(8676002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2422;H:DB6PR0401MB2536.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2016 06:49:51.2587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2422 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA86o9SU005285 Hi Arnd, > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Tuesday, November 08, 2016 5:20 AM > To: Y.B. Lu > Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org; > ulf.hansson@linaro.org; Scott Wood; Mark Rutland; Greg Kroah-Hartman; X.B. > Xie; M.H. Lian; linux-i2c@vger.kernel.org; linux-clk@vger.kernel.org; > Qiang Zhao; Russell King; Bhupesh Sharma; Joerg Roedel; Claudiu Manoil; > devicetree@vger.kernel.org; Rob Herring; Santosh Shilimkar; linux-arm- > kernel@lists.infradead.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Leo Li; iommu@lists.linux-foundation.org; Kumar > Gala > Subject: Re: [v15, 3/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl > > On Monday, October 31, 2016 9:35:33 AM CET Y.B. Lu wrote: > > > > > > I don't see any of the contents of this header referenced by the soc > > > driver any more. I think you can just drop this patch. > > > > > > > [Lu Yangbo-B47093] This header file was included by guts.c. > > The guts driver used macro SVR_MAJ/SVR_MIN for calculation. > > > > This header file was for powerpc arch before. And this patch is to > > made it as common header file for both ARM and PPC. > > Sooner or later this is needed. > > Let's discuss it once we actually need the header then, ok? [Lu Yangbo-B47093] As I said, this header file was included by guts.c in patch 4. The guts driver used macro SVR_MAJ/SVR_MIN for calculation which were defined in this header file. Did you suggest we dropped this patch and just calculated them in driver? Thanks :) > > Arnd