From: Meng Yi <meng.yi@nxp.com>
To: Stefan Agner <stefan@agner.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "alison.wang@freescale.com" <alison.wang@freescale.com>,
"jianwei.wang.chn@gmail.com" <jianwei.wang.chn@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/4] drm/fsl-dcu: update all registers on flush
Date: Wed, 7 Sep 2016 08:46:32 +0000 [thread overview]
Message-ID: <DB6PR0401MB263147AB1A6915CABE6A04ACECF80@DB6PR0401MB2631.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20160906040233.32471-4-stefan@agner.ch>
Hi Stefan,
Some comments below
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-
> dcu/fsl_dcu_drm_crtc.c
> index d30b61e..62eb284 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> @@ -27,6 +27,9 @@ static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc
> *crtc, {
> struct drm_pending_vblank_event *event = crtc->state->event;
>
> + regmap_write(fsl_dev->regmap,
> + DCU_UPDATE_MODE, DCU_UPDATE_MODE_READREG);
fsl_dev is not declared.
I had added these two lines when testing the patches.
struct drm_device *dev = crtc->dev;
struct fsl_dcu_drm_device *fsl_dev = dev->dev_private;
> +
> if (event) {
> crtc->state->event = NULL;
>
Best Regards,
Meng
next prev parent reply other threads:[~2016-09-07 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 4:02 [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Stefan Agner
2016-09-06 4:02 ` [PATCH 1/4] drm/fsl-dcu: support overlay and cursor planes Stefan Agner
2016-09-06 4:02 ` [PATCH 2/4] drm/fsl-dcu: respect pos/size register sizes Stefan Agner
2016-09-06 4:02 ` [PATCH 3/4] drm/fsl-dcu: update all registers on flush Stefan Agner
2016-09-07 8:46 ` Meng Yi [this message]
2016-09-06 4:02 ` [PATCH 4/4] drm/fsl-dcu: do not update when modifying irq registers Stefan Agner
2016-09-07 8:43 ` [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Meng Yi
2016-09-21 18:13 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0401MB263147AB1A6915CABE6A04ACECF80@DB6PR0401MB2631.eurprd04.prod.outlook.com \
--to=meng.yi@nxp.com \
--cc=alison.wang@freescale.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianwei.wang.chn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).