From: Kuldeep Singh <kuldeep.singh@nxp.com>
To: Rob Herring <robh@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Ashish Kumar <ashish.kumar@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
Date: Fri, 5 Mar 2021 11:16:08 +0000 [thread overview]
Message-ID: <DB6PR0402MB27589AE0E8D140292351DCCFE0969@DB6PR0402MB2758.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1614609861.083844.37863.nullmailer@robh.at.kernel.org>
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Monday, March 1, 2021 8:14 PM
> To: Kuldeep Singh <kuldeep.singh@nxp.com>
> Cc: devicetree@vger.kernel.org; Rob Herring <robh+dt@kernel.org>; Mark Brown
> <broonie@kernel.org>; Ashish Kumar <ashish.kumar@nxp.com>; linux-
> kernel@vger.kernel.org; linux-spi@vger.kernel.org
> Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
>
> Caution: EXT Email
>
> On Mon, 01 Mar 2021 15:34:06 +0530, Kuldeep Singh wrote:
> > Convert the NXP FlexSPI binding to DT schema format using json-schema.
> > Also, update MAINTAINERS to reflect the change.
> >
> > Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
> > ---
> > .../bindings/spi/nxp,spi-nxp-fspi.yaml | 101 ++++++++++++++++++
> > .../devicetree/bindings/spi/spi-nxp-fspi.txt | 42 --------
> > MAINTAINERS | 2 +-
> > 3 files changed, 102 insertions(+), 43 deletions(-) create mode
> > 100644 Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
> > delete mode 100644
> > Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml:
> properties:clocks:maxItems: False schema does not allow 2
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: ignoring,
> error in schema: properties: clocks: maxItems
> warning: no schema found in
> file: ./Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
> Error: Documentation/devicetree/bindings/spi/nxp,spi-nxp-
> fspi.example.dts:26.31-32 syntax error FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:349:
> Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.example.dt.yaml] Error
> 1
> make: *** [Makefile:1380: dt_binding_check] Error 2
>
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork
> .ozlabs.org%2Fpatch%2F1445509&data=04%7C01%7Ckuldeep.singh%40nxp.
> com%7Cb964d840a95e45dbf3cc08d8dcc08376%7C686ea1d3bc2b4c6fa92cd99c5c
> 301635%7C0%7C0%7C637502066681922692%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1
> 000&sdata=Ga5fpQ7oBEz8sQaA%2BtBZh75gPELe%2FDg6R5qJ2tZ2pB4%3D&
> amp;reserved=0
>
> This check can fail if there are any dependencies. The base for a patch series is
> generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above error(s), then
> make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
Thanks Rob for mentioning. I will make sure to run 'make dt_binding_check' before submitting next version.
Regards
Kuldeep
next prev parent reply other threads:[~2021-03-05 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 10:04 [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema Kuldeep Singh
2021-03-01 14:44 ` Rob Herring
2021-03-05 11:16 ` Kuldeep Singh [this message]
2021-03-09 10:35 Kuldeep Singh
2021-03-09 11:41 ` Kuldeep Singh
2021-03-09 12:36 ` Mark Brown
2021-03-09 17:30 ` [EXT] " Kuldeep Singh
2021-03-09 17:31 ` Mark Brown
2021-03-10 10:24 ` Kuldeep Singh
2021-03-10 12:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0402MB27589AE0E8D140292351DCCFE0969@DB6PR0402MB2758.eurprd04.prod.outlook.com \
--to=kuldeep.singh@nxp.com \
--cc=ashish.kumar@nxp.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).