From: Peng Fan <peng.fan@nxp.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "ohad@wizery.com" <ohad@wizery.com>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
"o.rempel@pengutronix.de" <o.rempel@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Zhu <hongxing.zhu@nxp.com>
Subject: RE: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message
Date: Mon, 7 Dec 2020 02:08:29 +0000 [thread overview]
Message-ID: <DB6PR0402MB2760019ACC7558DC48BF98C288CE0@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <X8rTnx/lQIxcuEXf@builder.lan>
> Subject: Re: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message
>
> On Fri 04 Dec 01:40 CST 2020, Peng Fan (OSS) wrote:
>
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > It is using devm_ioremap, so not devm_ioremap_resource. Correct the
> > error message and print out sa/size.
> >
> > Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > drivers/remoteproc/imx_rproc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index d1abb253b499..aa5fbd0c7768
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -270,7 +270,7 @@ static int imx_rproc_addr_init(struct imx_rproc
> *priv,
> > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> > att->sa, att->size);
> > if (!priv->mem[b].cpu_addr) {
> > - dev_err(dev, "devm_ioremap_resource failed\n");
> > + dev_err(dev, "devm_ioremap failed\n");
>
> I would prefer if this was expanded to a proper sentence, and I really like the
> second part of the commit message to be included in the change.
> So something like:
>
> dev_err(dev, "failed to remap %#x bytes from %#x\n",
> att->size, att->sa);
>
>
> And similarly below if mapping a memory-region fails.
ok, fix in v4.
Thanks,
Peng.
>
> Thanks,
> Bjorn
>
> > return -ENOMEM;
> > }
> > priv->mem[b].sys_addr = att->sa;
> > --
> > 2.28.0
> >
next prev parent reply other threads:[~2020-12-07 2:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 7:40 [PATCH V3 0/7] remoteproc: imx_rproc: support iMX8MQ/M Peng Fan (OSS)
2020-12-04 7:40 ` [PATCH V3 1/7] remoteproc: elf: support platform specific memory hook Peng Fan (OSS)
2020-12-05 0:16 ` Bjorn Andersson
2020-12-07 2:07 ` Peng Fan
2020-12-09 15:00 ` Peng Fan
2020-12-11 21:38 ` Mathieu Poirier
2020-12-10 16:54 ` Bjorn Andersson
2020-12-14 17:08 ` Mathieu Poirier
2020-12-04 7:40 ` [PATCH V3 2/7] remoteproc: imx_rproc: add elf memory hooks Peng Fan (OSS)
2020-12-04 7:40 ` [PATCH V3 3/7] remoteproc: imx_rproc: correct err message Peng Fan (OSS)
2020-12-05 0:26 ` Bjorn Andersson
2020-12-07 2:08 ` Peng Fan [this message]
2020-12-04 7:40 ` [PATCH V3 4/7] remoteproc: imx_rproc: use devm_ioremap Peng Fan (OSS)
2020-12-04 7:40 ` [PATCH V3 5/7] remoteproc: imx_rproc: add i.MX specific parse fw hook Peng Fan (OSS)
2020-12-04 7:40 ` [PATCH V3 6/7] remoteproc: imx_rproc: support i.MX8MQ/M Peng Fan (OSS)
2020-12-04 7:40 ` [PATCH V3 7/7] remoteproc: imx_proc: enable virtio/mailbox Peng Fan (OSS)
2020-12-05 0:44 ` Bjorn Andersson
2020-12-07 2:10 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0402MB2760019ACC7558DC48BF98C288CE0@DB6PR0402MB2760.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=o.rempel@pengutronix.de \
--cc=ohad@wizery.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).