From: Peng Fan <peng.fan@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios
Date: Tue, 8 Aug 2017 01:15:04 +0000 [thread overview]
Message-ID: <DB6PR04MB3221895A72F6B8635D8289DD888A0@DB6PR04MB3221.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5D6gUCjLstFLYEZ0e6eMAGgzff03BfJywB4znEct5gYMw@mail.gmail.com>
> > + chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable",
> GPIOD_OUT_LOW);
> > + if (IS_ERR(chip->enable_gpio)) {
> > + dev_dbg(&spi->dev, "No enable-gpios property\n");
> > + chip->enable_gpio = NULL;
>
> Also, the error handling here is not correct as it will never propagate
> EPROBE_DEFER.
>
> I will submit my version of the patch if you don't mind.
That's ok if you have a better patch.
Regards,
Peng.
prev parent reply other threads:[~2017-08-08 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 12:27 [PATCH 1/2] devicetree: gpio: 74x164: optional enable-gpios Peng Fan
2017-08-07 12:27 ` [PATCH 2/2] gpio: 74x164: handling enable-gpios Peng Fan
2017-08-07 12:36 ` Fabio Estevam
2017-08-07 12:40 ` Fabio Estevam
2017-08-08 1:15 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR04MB3221895A72F6B8635D8289DD888A0@DB6PR04MB3221.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).