From: Robin Gong <yibin.gong@nxp.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Russell King <linux@armlinux.org.uk>,
dl-linux-imx <linux-imx@nxp.com>,
"A.s. Dong" <aisheng.dong@nxp.com>
Subject: RE: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler
Date: Mon, 6 Aug 2018 02:51:38 +0000 [thread overview]
Message-ID: <DB6PR04MB3223921579ED18FDD802A73F89200@DB6PR04MB3223.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <403db02e-9c91-5080-ee9c-7a44716e64b2@pengutronix.de>
> >> +static struct pfuze_chip *syspm_pfuze_chip;
> >> +
> >> +static void pfuze_power_off_prepare(void)
> >> + dev_info(syspm_pfuze_chip->dev, "Configure standy mode for power
> >> +off");
> > Add 'if (syspm_pfuze_chip ->chip_id == PFUZE100))' here is easy for
> > extend Support on pfuze200/3000.. in the feature.
> There is already:
> static int pfuze_power_off_prepare_init(struct pfuze_chip *pfuze_chip) {
> if (pfuze_chip->chip_id != PFUZE100) {
> dev_warn(pfuze_chip->dev, "Requested
> pm_power_off_prepare handler for not supported chip\n");
> return -ENODEV;
> }
>
>
> No need to add it in pfuze_power_off_prepare()
I saw you add chip check in pfuze_power_off_prepare_init(), but I'm saying
In the future case pfuze200/3000 may should still support this feature, but registers
are different between different chips, thus, move checking chip into pfuze_power_off_prepare()
could make the later patch for pfuze200/3000 more clear, less and easier.
next prev parent reply other threads:[~2018-08-06 2:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 9:22 [PATCH v8 0/6] provide power off support for iMX6 with external PMIC Oleksij Rempel
2018-07-26 9:22 ` [PATCH v8 1/6] ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property Oleksij Rempel
2018-07-26 9:51 ` Robin Gong
2018-07-26 11:37 ` Oleksij Rempel
2018-07-27 1:51 ` Robin Gong
2018-07-27 8:30 ` Lucas Stach
2018-07-27 8:58 ` Robin Gong
2018-07-27 9:06 ` Oleksij Rempel
2018-07-30 8:03 ` Oleksij Rempel
2018-08-06 2:34 ` Robin Gong
2018-08-06 16:49 ` Lucas Stach
2018-07-27 8:41 ` Oleksij Rempel
2018-07-26 9:22 ` [PATCH v8 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set Oleksij Rempel
2018-07-27 9:15 ` Robin Gong
2018-07-30 7:57 ` Oleksij Rempel
2018-07-26 9:22 ` [PATCH v8 3/6] kernel/reboot.c: export pm_power_off_prepare Oleksij Rempel
2018-07-26 9:22 ` [PATCH v8 4/6] regulator: pfuze100: add fsl,pmic-stby-poweroff property Oleksij Rempel
2018-07-26 9:22 ` [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler Oleksij Rempel
2018-07-27 9:32 ` Robin Gong
2018-07-30 7:50 ` Oleksij Rempel
2018-07-30 10:24 ` Mark Brown
2018-08-02 8:11 ` Oleksij Rempel
2018-08-02 8:16 ` Oleksij Rempel
2018-08-06 2:51 ` Robin Gong [this message]
2018-07-26 9:22 ` [PATCH v8 6/6] ARM: dts: imx6: RIoTboard provide standby on power off option Oleksij Rempel
2018-07-27 9:33 ` Robin Gong
2018-07-30 7:58 ` Oleksij Rempel
2018-08-02 8:37 ` Oleksij Rempel
2018-07-26 9:48 ` [PATCH v8 0/6] provide power off support for iMX6 with external PMIC Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR04MB3223921579ED18FDD802A73F89200@DB6PR04MB3223.eurprd04.prod.outlook.com \
--to=yibin.gong@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=o.rempel@pengutronix.de \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).