linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alison Wang <alison.wang@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Leo Li <leoyang.li@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] arm64: dts: ls1028a: add pmu dt nodes
Date: Wed, 6 Mar 2019 08:25:08 +0000	[thread overview]
Message-ID: <DB7PR04MB4058729B6DDC6767647AD716F4730@DB7PR04MB4058.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190304014838.GV26041@dragon>

Hi, Shawn,

> On Wed, Feb 27, 2019 at 09:57:52AM +0800, Alison Wang wrote:
> > This patch adds pmu dt nodes for LS1028A.
> >
> > Signed-off-by: Alison Wang <alison.wang@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index a8cf92a..36ef9c5 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -89,6 +89,11 @@
> >  					  IRQ_TYPE_LEVEL_LOW)>;
> >  	};
> >
> > +	pmu {
> > +		compatible = "arm,armv8-pmuv3";
> 
> Shouldn't we use "arm,cortex-a72-pmu" as compatible for better?
> 
[Alison] Yes, it is better as compatible. I will change it in v2.
Thanks.


Best Regards,
Alison Wang

> Shawn
> 
> > +		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > +	};
> > +
> >  	gic: interrupt-controller@6000000 {
> >  		compatible= "arm,gic-v3";
> >  		#address-cells = <2>;
> > --
> > 1.7.1
> >

      reply	other threads:[~2019-03-06  8:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27  1:57 [PATCH] arm64: dts: ls1028a: add pmu dt nodes Alison Wang
2019-03-04  1:48 ` Shawn Guo
2019-03-06  8:25   ` Alison Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR04MB4058729B6DDC6767647AD716F4730@DB7PR04MB4058.eurprd04.prod.outlook.com \
    --to=alison.wang@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).