From: Biwen Li <biwen.li@nxp.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Trent Piepho <tpiepho@impinj.com>, Leo Li <leoyang.li@nxp.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [EXT] Re: [1/3] rtc/fsl: support flextimer for lx2160a
Date: Mon, 26 Aug 2019 10:37:18 +0000 [thread overview]
Message-ID: <DB7PR04MB4490446BD87B67AD4FB4A37F8FA10@DB7PR04MB4490.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190826101018.GC21713@piout.net>
>
> On 26/08/2019 03:37:43+0000, Biwen Li wrote:
> > >
> > > On Fri, 2019-08-23 at 17:57 +0800, Biwen Li wrote:
> > > > The patch supports flextimer for lx2160a
> > > >
> > > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > > ---
> > > > drivers/rtc/rtc-fsl-ftm-alarm.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > > b/drivers/rtc/rtc-fsl- ftm-alarm.c index
> > > > 4f7259c2d6a3..2b81525f6db8 100644
> > > > --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > > +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > > @@ -313,6 +313,7 @@ static const struct of_device_id
> > > > ftm_rtc_match[] = {
> > > > { .compatible = "fsl,ls1088a-ftm-alarm", },
> > > > { .compatible = "fsl,ls208xa-ftm-alarm", },
> > > > { .compatible = "fsl,ls1028a-ftm-alarm", },
> > > > + { .compatible = "fsl,lx2160a-ftm-alarm", },
> > > > { },
> > > > };
> > > >
> > >
> > > Since there's no data associated with each compatible, it doesn't
> > > seem like there's any need to add a new one.
> > >
> > > What's normally done is add two compatibles in the dts, the base
> > > version and the specific version, e.g.:
> > >
> > > + rcpm: rcpm@1e34040 {
> > > + compatible = "fsl,lx2160a-rcpm",
> > > + "fsl,qoriq-cpm-2.1+";
> > >
> > > Or in this case, compatible = "fsl,lx2160a-ftm-alarm",
> > > "fsl,ls1088a-ftm-alarm";
> > >
> > > Then there's no need to add to the driver list.
> > Yes, it will be work. But it will be confusing. Is ls1088a same with lx2160a? No.
>
> Well, if you are sure it is the exact same IP that is used, then you should only use
> one compatible. We usually use the name of the first SoC that had the IP. Is it
> confusing anyone? Probably not because this will be in a dtsi that nobody will
> read.
>
> Note that adding so many compatbile will increase the boot time of your
> platform and this is annoying many NXP customers of the i.mx line.
Yeah, that makes sense.
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.
> com&data=02%7C01%7Cbiwen.li%40nxp.com%7C3f6abbd69663483bc4
> a708d72a0d9999%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6
> 37024110214068297&sdata=Zh2eYNYt9IjWdf6jCdqY3BI%2F%2Fstgcqmq
> Ai7R%2Bm2dD2I%3D&reserved=0
prev parent reply other threads:[~2019-08-26 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 9:57 [1/3] rtc/fsl: support flextimer for lx2160a Biwen Li
2019-08-23 9:57 ` [2/3] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
2019-08-23 9:57 ` [3/3] rtc/fsl: support flextimer for SoC LS1021A (ARM32) Biwen Li
2019-08-23 12:43 ` [1/3] rtc/fsl: support flextimer for lx2160a Alexandre Belloni
2019-08-23 14:25 ` Alexandre Belloni
2019-08-26 3:30 ` [EXT] " Biwen Li
2019-08-23 16:56 ` Trent Piepho
2019-08-26 3:37 ` [EXT] " Biwen Li
2019-08-26 10:10 ` Alexandre Belloni
2019-08-26 10:37 ` Biwen Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB4490446BD87B67AD4FB4A37F8FA10@DB7PR04MB4490.eurprd04.prod.outlook.com \
--to=biwen.li@nxp.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).