From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"wg@grandegger.com" <wg@grandegger.com>,
"mkl@pengutronix.de" <mkl@pengutronix.de>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"A.s. Dong" <aisheng.dong@nxp.com>
Subject: RE: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree
Date: Thu, 25 Oct 2018 00:40:47 +0000 [thread overview]
Message-ID: <DB7PR04MB4618F0289926D923EB908A14E6F70@DB7PR04MB4618.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181024235706.GA22938@bogus>
-----Original Message-----
From: Rob Herring [mailto:robh@kernel.org]
Sent: 2018年10月25日 7:57
To: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: linux-can@vger.kernel.org; wg@grandegger.com; mkl@pengutronix.de; mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; A.s. Dong <aisheng.dong@nxp.com>
Subject: Re: [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree
On Tue, Oct 23, 2018 at 05:17:10AM +0000, Joakim Zhang wrote:
> From: Dong Aisheng <aisheng.dong@nxp.com>
>
> The FlexCAN controller can parse the stop-mode property to enable CAN
> self wakeup feature.
>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> ---
> Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 8
> ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index bfc0c433654f..b5ccfc9c14fb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -24,6 +24,14 @@ Optional properties:
> if this property is present then controller is assumed to be big
> endian.
>
> +- stop-mode: register bits of stop mode control, the format is
Should have a vendor prefix: fsl,stop-mode
Okay, I will add it. Thanks a lot!
Best Regards,
Joakim Zhang
> + <&gpr req_gpr req_bit ack_gpr ack_bit>.
> + gpr is the phandle to general purpose register node.
> + req_gpr is the gpr register offset of CAN stop request.
> + req_bit is the bit offset of CAN stop request.
> + ack_gpr is the gpr register offset of CAN stop acknowledge.
> + ack_bit is the bit offset of CAN stop acknowledge.
> +
> Example:
>
> can@1c000 {
> --
> 2.17.1
>
prev parent reply other threads:[~2018-10-25 0:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 5:17 [PATCH V1 0/2] can: flexcan: Add CAN self wakeup support Joakim Zhang
2018-10-23 5:17 ` [PATCH V1 1/2] can: flexcan: Add " Joakim Zhang
2018-10-23 5:17 ` [PATCH V1 2/2] Documentation: can: flexcan: Add stop-mode property to device tree Joakim Zhang
2018-10-24 23:57 ` Rob Herring
2018-10-25 0:40 ` Joakim Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB4618F0289926D923EB908A14E6F70@DB7PR04MB4618.eurprd04.prod.outlook.com \
--to=qiangqing.zhang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).