From: Sandor Yu <sandor.yu@nxp.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"andrzej.hajda@intel.com" <andrzej.hajda@intel.com>,
"robert.foss@linaro.org" <robert.foss@linaro.org>,
"Laurent.pinchart@ideasonboard.com"
<Laurent.pinchart@ideasonboard.com>,
"jonas@kwiboo.se" <jonas@kwiboo.se>,
"jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>
Cc: "S.J. Wang" <shengjiu.wang@nxp.com>,
"cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
"maxime@cerno.tech" <maxime@cerno.tech>,
"harry.wentland@amd.com" <harry.wentland@amd.com>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"amuel@sholland.org" <amuel@sholland.org>
Subject: RE: [EXT] Re: [PATCH v1 2/5] drm: bridge: dw_hdmi: enable overflow workaround for v2.13a
Date: Thu, 7 Apr 2022 08:30:46 +0000 [thread overview]
Message-ID: <DB7PR04MB5450ABCC4E1CAA262DCCA7C4F4E69@DB7PR04MB5450.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <45668d73-a9fb-b23a-fb32-2e50eb4982aa@baylibre.com>
Hi,
> -----Original Message-----
> From: Neil Armstrong <narmstrong@baylibre.com>
> Sent: 2022年4月6日 17:17
> To: Sandor Yu <sandor.yu@nxp.com>; dri-devel@lists.freedesktop.org;
> linux-kernel@vger.kernel.org; andrzej.hajda@intel.com;
> robert.foss@linaro.org; Laurent.pinchart@ideasonboard.com;
> jonas@kwiboo.se; jernej.skrabec@gmail.com
> Cc: S.J. Wang <shengjiu.wang@nxp.com>; cai.huoqing@linux.dev;
> maxime@cerno.tech; harry.wentland@amd.com; hverkuil-cisco@xs4all.nl;
> amuel@sholland.org
> Subject: [EXT] Re: [PATCH v1 2/5] drm: bridge: dw_hdmi: enable overflow
> workaround for v2.13a
>
> Caution: EXT Email
>
> Hi,
>
> On 06/04/2022 10:48, Sandor.yu@nxp.com wrote:
> > From: Sandor Yu <Sandor.yu@nxp.com>
> >
> > iMX865 HDMI (v2.13a) have been identified as needing the workaround.
> > Tests show that one iteration is enough.
> >
> > Without the workaround, iMX865 HDMI audio may not work after cable
> > plugout/in, because HDMI mode is not really set in register
> > HDMI_FC_INVIDCONF.
> >
> > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
> > ---
> > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > index 4befc104d220..b11577de4836 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -2087,9 +2087,9 @@ static void dw_hdmi_clear_overflow(struct
> dw_hdmi *hdmi)
> > *
> > * The number of iterations matters and depends on the HDMI TX
> revision
> > * (and possibly on the platform). So far i.MX6Q (v1.30a), i.MX6DL
> > - * (v1.31a) and multiple Allwinner SoCs (v1.32a) have been
> identified
> > - * as needing the workaround, with 4 iterations for v1.30a and 1
> > - * iteration for others.
> > + * (v1.31a), iMX865(v2.13a) and multiple Allwinner SoCs (v1.32a)
> > + * have been identified as needing the workaround,
> > + * with 4 iterations for v1.30a and 1 iteration for others.
> > * The Amlogic Meson GX SoCs (v2.01a) have been identified as
> needing
> > * the workaround with a single iteration.
> > * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs
> > (v2.11a) have @@ -2106,6 +2106,7 @@ static void
> dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> > case 0x201a:
> > case 0x211a:
> > case 0x212a:
> > + case 0x213a:
> > count = 1;
> > break;
>
> At some point we must consider only v1.30a needs 4, and other needs 1.
>
> It would be simpler to put the "count = 1" in a default case.
>
Agree, I will put the "count = 1 " to default case.
> The comment change is still welcome so we can track.
>
> Thanks,
> Neil
>
> > default:
Thanks
Sandor
next prev parent reply other threads:[~2022-04-07 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 8:48 [PATCH v1 0/5] DRM: Bridge: DW_HDMI: Add new features and bug fix Sandor.yu
2022-04-06 8:48 ` [PATCH v1 1/5] drm: bridge: dw_hdmi: cec: Add cec suspend/resume function Sandor.yu
2022-04-06 9:46 ` Hans Verkuil
2022-04-07 8:30 ` [EXT] " Sandor Yu
2022-04-06 8:48 ` [PATCH v1 2/5] drm: bridge: dw_hdmi: enable overflow workaround for v2.13a Sandor.yu
2022-04-06 9:17 ` Neil Armstrong
2022-04-07 8:30 ` Sandor Yu [this message]
2022-04-06 8:48 ` [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for Deep Color Sandor.yu
2022-04-06 9:20 ` Neil Armstrong
2022-04-07 8:31 ` [EXT] " Sandor Yu
2022-04-06 8:48 ` [PATCH v1 4/5] drm: bridge: dw_hdmi: add reset function for PHY GEN1 Sandor.yu
2022-04-06 8:48 ` [PATCH v1 5/5] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver Sandor.yu
2022-04-06 9:27 ` Neil Armstrong
2022-04-07 8:31 ` [EXT] " Sandor Yu
2022-04-07 8:43 ` [PATCH v1 0/5] DRM: Bridge: DW_HDMI: Add new features and bug fix Philipp Zabel
2022-04-07 11:46 ` [EXT] " Sandor Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB5450ABCC4E1CAA262DCCA7C4F4E69@DB7PR04MB5450.eurprd04.prod.outlook.com \
--to=sandor.yu@nxp.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=amuel@sholland.org \
--cc=andrzej.hajda@intel.com \
--cc=cai.huoqing@linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).