From: Sven Schuchmann <schuchmann@schleissheimer.de>
To: Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>
Cc: Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH v1] leds: lp50xx: add setting of default intensity from DT
Date: Thu, 4 Feb 2021 07:31:26 +0000 [thread overview]
Message-ID: <DB8P190MB0634002C60A8680823421A69D9B39@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210203172302.GB23019@duo.ucw.cz>
Hello Pavel, hello Marek
> > Is the property default-intensity documented in DT bindings?
I updated the documentation in leds-lp50xx.yaml. Is it this what you mean?
> > Wouldn't it be better if the property was used in the multi-led node
> > instead of the channel node? I.e.
> > multi-led@3 {
> > color = <LED_COLOR_ID_RGB>;
> > default-intensity = <100 0 0>;
> > };
>
> Yes, this would be better.
Sound good, I will see what I can do here.
Regards, Sven
prev parent reply other threads:[~2021-02-04 7:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 10:53 [PATCH v1] leds: lp50xx: add setting of default intensity from DT Sven Schuchmann
2021-02-02 10:48 ` AW: " Sven Schuchmann
2021-02-02 18:24 ` Jacek Anaszewski
2021-02-03 14:29 ` Pavel Machek
2021-02-03 15:39 ` AW: " Sven Schuchmann
2021-02-03 16:35 ` Pavel Machek
2021-02-03 17:10 ` AW: " Sven Schuchmann
2021-02-03 17:25 ` Pavel Machek
2021-02-04 7:32 ` AW: " Sven Schuchmann
2021-02-03 17:21 ` Marek Behun
2021-02-03 17:23 ` Pavel Machek
2021-02-04 7:31 ` Sven Schuchmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8P190MB0634002C60A8680823421A69D9B39@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM \
--to=schuchmann@schleissheimer.de \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).