From: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
Yannick Vignon <yannick.vignon@nxp.com>,
"boon.leong.ong@intel.com" <boon.leong.ong@intel.com>,
"Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
"mst@redhat.com" <mst@redhat.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
Mingkai Hu <mingkai.hu@nxp.com>, Leo Li <leoyang.li@nxp.com>
Subject: RE: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get underflow error from DMA descriptor
Date: Mon, 13 Dec 2021 00:49:03 +0000 [thread overview]
Message-ID: <DB8PR04MB5785AC0B2197DC4EBD28B146F0749@DB8PR04MB5785.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20211210080636.3c1ab98f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 11 Dec 2021 00:07:13 Jakub Kicinski wrote:
> > > > 5 queues with FIFO cut-through mode can work well after applying this
> patch.
> > >
> > > This never worked, correct? It's not a regression fix?
> >
> > Yes, it's never worked when the underflow error is observed in the
> > case of NFS boot on i.mx8mp. I'm not sure if other SoC have same issue
> > in this case, but I think it's necessary to increase the threshold
> > value in case of underflow error.
>
> Oh, so NFS boot works for the most part on i.mx8mp but under certain
> conditions (or with certain configuration?) this error can be observed and the
> boot will fail?
Yes, when configure the DMA as threshold mode, this error can be observed.
>
> > Do you mean that I need to send the patch as a bug fix to net branch?
>
> Your call, if you would like for the patch to go to stable and LTS releases -- then
> it need to be resent for net with a Fixes tag.
>
> LMK if you prefer net or net-next.
Because this error requires a certain condition in DTS file, and I haven't update the DTS file. So I prefer to add the patch in net-next, thanks.
next prev parent reply other threads:[~2021-12-13 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 10:06 [PATCH net-next] net: stmmac: bump tc when get underflow error from DMA descriptor Xiaoliang Yang
2021-12-09 1:31 ` Joakim Zhang
2021-12-10 2:41 ` Jakub Kicinski
2021-12-10 3:11 ` [EXT] " Xiaoliang Yang
2021-12-10 16:06 ` Jakub Kicinski
2021-12-13 0:49 ` Xiaoliang Yang [this message]
2021-12-13 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR04MB5785AC0B2197DC4EBD28B146F0749@DB8PR04MB5785.eurprd04.prod.outlook.com \
--to=xiaoliang.yang_1@nxp.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=yannick.vignon@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).