From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V1 4/5] net: fec: add eee mode tx lpi support
Date: Mon, 9 Aug 2021 05:11:31 +0000 [thread overview]
Message-ID: <DB8PR04MB67956C9894A1F77FF537A731E6F69@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210809014043.GA3712165@roeck-us.net>
Hi Guenter,
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: 2021年8月9日 9:41
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: davem@davemloft.net; kuba@kernel.org; robh+dt@kernel.org;
> andrew@lunn.ch; netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V1 4/5] net: fec: add eee mode tx lpi support
>
> On Fri, Jul 09, 2021 at 03:53:54PM +0800, Joakim Zhang wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > The i.MX8MQ ENET version support IEEE802.3az eee mode, add eee mode tx
> > lpi enable to support ethtool interface.
> >
> > usage:
> > 1. set sleep and wake timer to 5ms:
> > ethtool --set-eee eth0 eee on tx-lpi on tx-timer 5000 2. check the eee
> > mode:
> > ~# ethtool --show-eee eth0
> > EEE Settings for eth0:
> > EEE status: enabled - active
> > Tx LPI: 5000 (us)
> > Supported EEE link modes: 100baseT/Full
> > 1000baseT/Full
> > Advertised EEE link modes: 100baseT/Full
> > 1000baseT/Full
> > Link partner advertised EEE link modes: 100baseT/Full
> >
> > Note: For realtime case and IEEE1588 ptp case, it should disable EEE
> > mode.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
>
> This patch results in:
>
> drivers/net/ethernet/freescale/fec_main.c: In function
> 'fec_enet_eee_mode_set':
> drivers/net/ethernet/freescale/fec_main.c:2801:40: error: 'FEC_LPI_SLEEP'
> undeclared
> drivers/net/ethernet/freescale/fec_main.c:2802:39: error: 'FEC_LPI_WAKE'
> undeclared
>
> when building m68k:m5272c3_defconfig.
I just sent to patch to fix this build issue, sorry for this inconvenience.
Best Regards,
Joakim Zhang
> Guenter
next prev parent reply other threads:[~2021-08-09 5:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 7:53 [PATCH V1 0/5] net: fec: add support for i.MX8MQ and i.MX8QM Joakim Zhang
2021-07-09 7:53 ` [PATCH V1 1/5] dt-bindings: fec: add the missing clocks properties Joakim Zhang
2021-07-09 7:53 ` [PATCH V1 2/5] dt-bindings: fec: add RGMII delayed clock property Joakim Zhang
2021-07-09 7:53 ` [PATCH V1 3/5] net: fec: add imx8mq and imx8qm new versions support Joakim Zhang
2021-07-09 7:53 ` [PATCH V1 4/5] net: fec: add eee mode tx lpi support Joakim Zhang
2021-08-09 1:40 ` Guenter Roeck
2021-08-09 5:11 ` Joakim Zhang [this message]
2021-07-09 7:53 ` [PATCH V1 5/5] net: fec: add MAC internal delayed clock feature support Joakim Zhang
2021-07-09 8:16 ` [PATCH V1 0/5] net: fec: add support for i.MX8MQ and i.MX8QM Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR04MB67956C9894A1F77FF537A731E6F69@DB8PR04MB6795.eurprd04.prod.outlook.com \
--to=qiangqing.zhang@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).