linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations
Date: Tue, 25 May 2021 09:46:27 +0000	[thread overview]
Message-ID: <DB8PR04MB67957EA8964DB8CE625F6CFFE6259@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <YKpqtK7YBVFnqRSw@lunn.ch>


Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: 2021年5月23日 22:46
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: davem@davemloft.net; kuba@kernel.org; frieder.schrempf@kontron.de;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: Re: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX
> bandwidth fluctuations
> 
> On Sun, May 23, 2021 at 06:20:19PM +0800, Joakim Zhang wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > As we know that AVB is enabled by default, and the ENET IP design is
> > queue 0 for best effort, queue 1&2 for AVB Class A&B. Bandwidth of
> > queue 1&2 set in driver is 50%, TX bandwidth fluctuated when selecting
> > tx queues randomly with FEC_QUIRK_HAS_AVB quirk available.
> 
> How is the driver currently scheduling between these queues? Given the
> 802.1q priorities, i think we want queue 2 with the highest priority for
> scheduling. Then queue 0 and lastly queue 1.

I think currently there is no schedule between these queues in the driver.

Could you please point me where I can find mapping between priorities and queues? You prefer to below mapping?
static const u16 fec_enet_vlan_pri_to_queue[8] = {1, 1, 0, 0, 0, 2, 2, 2};

Best Regards,
Joakim Zhang
>     Andrew

  reply	other threads:[~2021-05-25  9:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 10:20 [RFC net-next 0/2] net: fec: " Joakim Zhang
2021-05-23 10:20 ` [RFC net-next 1/2] net: fec: add FEC_QUIRK_HAS_MULTI_QUEUES represents i.MX6SX ENET IP Joakim Zhang
2021-05-23 10:20 ` [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations Joakim Zhang
2021-05-23 14:38   ` Andrew Lunn
2021-05-25  9:44     ` Joakim Zhang
2021-05-23 14:46   ` Andrew Lunn
2021-05-25  9:46     ` Joakim Zhang [this message]
2021-05-25 13:58       ` Andrew Lunn
2021-05-26  2:06         ` Joakim Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8PR04MB67957EA8964DB8CE625F6CFFE6259@DB8PR04MB6795.eurprd04.prod.outlook.com \
    --to=qiangqing.zhang@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=frieder.schrempf@kontron.de \
    --cc=kuba@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='RE: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox