From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
Date: Tue, 3 Aug 2021 02:01:21 +0000 [thread overview]
Message-ID: <DB8PR04MB6795B1DA6A99BB90F82AD4EAE6F09@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210802133230.1a17ac4c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: 2021年8月3日 4:33
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: davem@davemloft.net; andrew@lunn.ch; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
>
> On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
> > @@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
> > fep->phy_interface = interface;
> > }
> >
> > + ret = fec_enet_parse_rgmii_delay(fep, np);
> > + if (ret)
> > + goto failed_phy;
>
> You're jumping to the wrong label, it looks like phy_node needs to be released
> at this point.
Yes, I will correct it. Thanks Jakub.
Best Regards,
Joakim Zhang
prev parent reply other threads:[~2021-08-03 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 11:47 [PATCH net-next] net: fec: fix MAC internal delay doesn't work Joakim Zhang
2021-08-02 20:32 ` Jakub Kicinski
2021-08-03 2:01 ` Joakim Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR04MB6795B1DA6A99BB90F82AD4EAE6F09@DB8PR04MB6795.eurprd04.prod.outlook.com \
--to=qiangqing.zhang@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).