From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Arnd Bergmann <arnd@arndb.de>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dpaa2-eth: debugfs: use div64_u64 for division
Date: Wed, 29 Apr 2020 09:18:04 +0000 [thread overview]
Message-ID: <DB8PR04MB6828071573BDB80739446C38E0AD0@DB8PR04MB6828.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200429084740.2665893-1-arnd@arndb.de>
> Subject: [PATCH] dpaa2-eth: debugfs: use div64_u64 for division
>
> A plain 64-bit division breaks building on 32-bit architectures:
>
> ERROR: modpost: "__aeabi_uldivmod"
> [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined!
>
> As this function is not performance critical, just use the external helper instead.
>
> Fixes: 460fd830dd9d ("dpaa2-eth: add channel stat to debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the patch.
A fix for this was applied some hours ago on the net-next branch.
--
Ioana
> ---
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> index 80291afff3ea..0a31e4268dfb 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
> @@ -139,7 +139,7 @@ static int dpaa2_dbg_ch_show(struct seq_file *file, void
> *offset)
> ch->stats.dequeue_portal_busy,
> ch->stats.frames,
> ch->stats.cdan,
> - ch->stats.frames / ch->stats.cdan,
> + div64_u64(ch->stats.frames, ch->stats.cdan),
> ch->buf_count);
> }
>
> --
> 2.26.0
prev parent reply other threads:[~2020-04-29 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 8:47 [PATCH] dpaa2-eth: debugfs: use div64_u64 for division Arnd Bergmann
2020-04-29 9:18 ` Ioana Ciornei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR04MB6828071573BDB80739446C38E0AD0@DB8PR04MB6828.eurprd04.prod.outlook.com \
--to=ioana.ciornei@nxp.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).