* [PATCH 1/1] mfd: da9055: Use DEFINE_RES_IRQ_NAMED() to simplify code
@ 2021-06-01 7:28 Zhen Lei
2021-06-08 13:28 ` Adam Thomson
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-06-01 7:28 UTC (permalink / raw)
To: Support Opensource, Lee Jones, linux-kernel; +Cc: Zhen Lei
No functional change.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/mfd/da9055-core.c | 38 ++++++++------------------------------
1 file changed, 8 insertions(+), 30 deletions(-)
diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
index d074d213e66170b..c3bcbd8905c6cfa 100644
--- a/drivers/mfd/da9055-core.c
+++ b/drivers/mfd/da9055-core.c
@@ -254,41 +254,19 @@ const struct regmap_config da9055_regmap_config = {
};
EXPORT_SYMBOL_GPL(da9055_regmap_config);
-static const struct resource da9055_onkey_resource = {
- .name = "ONKEY",
- .start = DA9055_IRQ_NONKEY,
- .end = DA9055_IRQ_NONKEY,
- .flags = IORESOURCE_IRQ,
-};
+static const struct resource da9055_onkey_resource =
+ DEFINE_RES_IRQ_NAMED(DA9055_IRQ_NONKEY, "ONKEY");
static const struct resource da9055_rtc_resource[] = {
- {
- .name = "ALM",
- .start = DA9055_IRQ_ALARM,
- .end = DA9055_IRQ_ALARM,
- .flags = IORESOURCE_IRQ,
- },
- {
- .name = "TICK",
- .start = DA9055_IRQ_TICK,
- .end = DA9055_IRQ_TICK,
- .flags = IORESOURCE_IRQ,
- },
+ DEFINE_RES_IRQ_NAMED(DA9055_IRQ_ALARM, "ALM"),
+ DEFINE_RES_IRQ_NAMED(DA9055_IRQ_TICK, "TICK"),
};
-static const struct resource da9055_hwmon_resource = {
- .name = "HWMON",
- .start = DA9055_IRQ_HWMON,
- .end = DA9055_IRQ_HWMON,
- .flags = IORESOURCE_IRQ,
-};
+static const struct resource da9055_hwmon_resource =
+ DEFINE_RES_IRQ_NAMED(DA9055_IRQ_HWMON, "HWMON");
-static const struct resource da9055_ld05_6_resource = {
- .name = "REGULATOR",
- .start = DA9055_IRQ_REGULATOR,
- .end = DA9055_IRQ_REGULATOR,
- .flags = IORESOURCE_IRQ,
-};
+static const struct resource da9055_ld05_6_resource =
+ DEFINE_RES_IRQ_NAMED(DA9055_IRQ_REGULATOR, "REGULATOR");
static const struct mfd_cell da9055_devs[] = {
{
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 1/1] mfd: da9055: Use DEFINE_RES_IRQ_NAMED() to simplify code
2021-06-01 7:28 [PATCH 1/1] mfd: da9055: Use DEFINE_RES_IRQ_NAMED() to simplify code Zhen Lei
@ 2021-06-08 13:28 ` Adam Thomson
0 siblings, 0 replies; 2+ messages in thread
From: Adam Thomson @ 2021-06-08 13:28 UTC (permalink / raw)
To: Zhen Lei, Support Opensource, Lee Jones, linux-kernel
On 01 June 2021 08:29, Zhen Lei wrote:
> No functional change.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
> drivers/mfd/da9055-core.c | 38 ++++++++------------------------------
> 1 file changed, 8 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
> index d074d213e66170b..c3bcbd8905c6cfa 100644
> --- a/drivers/mfd/da9055-core.c
> +++ b/drivers/mfd/da9055-core.c
> @@ -254,41 +254,19 @@ const struct regmap_config da9055_regmap_config = {
> };
> EXPORT_SYMBOL_GPL(da9055_regmap_config);
>
> -static const struct resource da9055_onkey_resource = {
> - .name = "ONKEY",
> - .start = DA9055_IRQ_NONKEY,
> - .end = DA9055_IRQ_NONKEY,
> - .flags = IORESOURCE_IRQ,
> -};
> +static const struct resource da9055_onkey_resource =
> + DEFINE_RES_IRQ_NAMED(DA9055_IRQ_NONKEY, "ONKEY");
>
> static const struct resource da9055_rtc_resource[] = {
> - {
> - .name = "ALM",
> - .start = DA9055_IRQ_ALARM,
> - .end = DA9055_IRQ_ALARM,
> - .flags = IORESOURCE_IRQ,
> - },
> - {
> - .name = "TICK",
> - .start = DA9055_IRQ_TICK,
> - .end = DA9055_IRQ_TICK,
> - .flags = IORESOURCE_IRQ,
> - },
> + DEFINE_RES_IRQ_NAMED(DA9055_IRQ_ALARM, "ALM"),
> + DEFINE_RES_IRQ_NAMED(DA9055_IRQ_TICK, "TICK"),
> };
>
> -static const struct resource da9055_hwmon_resource = {
> - .name = "HWMON",
> - .start = DA9055_IRQ_HWMON,
> - .end = DA9055_IRQ_HWMON,
> - .flags = IORESOURCE_IRQ,
> -};
> +static const struct resource da9055_hwmon_resource =
> + DEFINE_RES_IRQ_NAMED(DA9055_IRQ_HWMON, "HWMON");
>
> -static const struct resource da9055_ld05_6_resource = {
> - .name = "REGULATOR",
> - .start = DA9055_IRQ_REGULATOR,
> - .end = DA9055_IRQ_REGULATOR,
> - .flags = IORESOURCE_IRQ,
> -};
> +static const struct resource da9055_ld05_6_resource =
> + DEFINE_RES_IRQ_NAMED(DA9055_IRQ_REGULATOR, "REGULATOR");
>
> static const struct mfd_cell da9055_devs[] = {
> {
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-08 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 7:28 [PATCH 1/1] mfd: da9055: Use DEFINE_RES_IRQ_NAMED() to simplify code Zhen Lei
2021-06-08 13:28 ` Adam Thomson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).