From: "Starke, Daniel" <daniel.starke@siemens.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/9] tty: n_gsm: fix user open not possible at responder until initiator open
Date: Mon, 23 May 2022 08:45:06 +0000 [thread overview]
Message-ID: <DB9PR10MB58810877B0B37B6212471415E0D49@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM> (raw)
> > +/**
> > + * gsm_dlci_wait_open - wait for channel open procedure
> > + * @dlci: DLCI to open
> > + *
> > + * Wait for a DLCI opening from the other side. Asynchronously wait until
> > + * we get a SABM and set off timers and the responses.
> > + */
> > +static void gsm_dlci_wait_open(struct gsm_dlci *dlci) {
> > + switch (dlci->state) {
> > + case DLCI_CLOSED:
> > + case DLCI_CLOSING:
> > + dlci->state = DLCI_OPENING;
> > + break;
> > + default:
> > + break;
> > + }
> > +}
>
> The documentation for this function is odd, you are not waiting for
> anything. You are just changing the state. This makes no sense as-is,
> sorry.
Thank you for your comment. I have prepared a new version. I will send it
after the other 8 patches have been commented.
Best regards,
Daniel Starke
next reply other threads:[~2022-05-23 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:45 Starke, Daniel [this message]
2022-05-23 12:09 ` [PATCH v2 1/9] tty: n_gsm: fix user open not possible at responder until initiator open Greg KH
-- strict thread matches above, loose matches on Subject: below --
2022-05-19 7:07 D. Starke
2022-05-19 16:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR10MB58810877B0B37B6212471415E0D49@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM \
--to=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).