From: Hartley Sweeten <HartleyS@visionengravers.com>
To: Ian Abbott <abbotti@mev.co.uk>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: comedi: ni_at_a2150: range check board index
Date: Wed, 3 Sep 2014 17:03:14 +0000 [thread overview]
Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D8825F8630C@P3PWEX4MB008.ex4.secureserver.net> (raw)
In-Reply-To: <1409577210-964-1-git-send-email-abbotti@mev.co.uk>
On Monday, September 01, 2014 6:14 AM, Ian Abbott wrote:
> The "ni_at_a2150" driver determines the board type by calling
> `a2150_probe()`. This reads a register and converts it to a board index
> in the range 0 to 3. However, the board table array it indexes into
> (`a2150_boards[]`) only has 2 entries. Return an error from the
> Comedi driver "attach" handler `a2150_attach()` if the probed board
> index is beyond the end of the array.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
prev parent reply other threads:[~2014-09-03 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 13:13 [PATCH] staging: comedi: ni_at_a2150: range check board index Ian Abbott
2014-09-03 17:03 ` Hartley Sweeten [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC148C5AA1CEBA4E87973D432B1C2D8825F8630C@P3PWEX4MB008.ex4.secureserver.net \
--to=hartleys@visionengravers.com \
--cc=abbotti@mev.co.uk \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).