From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752612AbaIKR5h (ORCPT ); Thu, 11 Sep 2014 13:57:37 -0400 Received: from p3plex2out04.prod.phx3.secureserver.net ([184.168.131.18]:58422 "EHLO p3plex2out04.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbaIKR5g convert rfc822-to-8bit (ORCPT ); Thu, 11 Sep 2014 13:57:36 -0400 From: Hartley Sweeten To: Greg Kroah-Hartman CC: Ian Abbott , "driverdev-devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 00/48] staging: comedi: avoid using comedi_board() Thread-Topic: [PATCH 00/48] staging: comedi: avoid using comedi_board() Thread-Index: AQHPzBidpyB9E37aHUyfPTFUHQsjBpv8NngQ Date: Thu, 11 Sep 2014 17:57:34 +0000 Message-ID: References: <1410258417-28230-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1410258417-28230-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 09, 2014 3:26 AM, Ian Abbott wrote: > The `comedi_board` inline function takes a single parameter of type > `struct comedi_device *` and merely returns the value of the `board_ptr` > member therein. This is somewhat superfluous as the member can be > accessed directly. > > Replace all uses of `comedi_board(dev)` with `dev->board_ptr`. > > Note, if there are any conflicts when applying this series, they can > just be skipped for now and corrected later. > > A subsequent patch will remove the `comedi_board` function, once there > is nothing using it. Greg, Just wanted to give you a heads up on this series and the ones I have posted. The series are: >>From Ian, [PATCH 00/48] staging: comedi: avoid using comedi_board() >>From me, [PATCH 00/30] staging: comedi: adl_pci9118: continue cleanup >>From me, [PATCH 00/34] staging: comedi: cleanup async cmd->stop_{src,arg} usage There are a couple conflicts between the series from Ian and my two. If you drop these two from Ian's series: 06) staging: comedi: adl_pci9118: replace comedi_board() calls 10) staging: comedi: amplc_dio200_common: replace comedi_board() calls The rest will apply cleanly in the order above (assuming I didn't miss anything). Also, Ian had a couple issues with patch 07/34 and 08/34 from the last series I posted. I already asked if you could drop those two. I needed I will repost the series. Thanks, Hartley